You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
String identifier for each layer in the network #3966
hey there would love to join in to help, i was curious in what way do you need the string identifier to work
as is it something for the user side we looking so the code writing and reading is easy or internal handling ?
hey there would love to join in to help, i was curious in what way do you need the string identifier to work as is it something for the user side we looking so the code writing and reading is easy or internal handling ?
With DAGNetwork, when adding a layer it returns an id (just an index into a std::vector). The idea with this issue is the user may want to use a std::string instead. This goes for the FFN and RNN classes too.
Ok so I was thinking we can change the multilayer.h file so tht while adding layer to the network one can give name to which can stored in a hashmap and can be accessed also with this hashmap
@andrewfurey21 ok so i did some testing with my code and i did get a good thing all the tests pass and no issues with that and all the old code is still compatible just that i have to write a new test for the layer identifiers @andrewfurey21 can i make a pr so you can review it ??
Hi is this still open? Saw the messages above from FreezB11 and AshwathElang0 about it. I am interested in trying this if no one's working on it right now.
Activity
rcurtin commentedon Aug 27, 2025
This one is actually important to do, although we haven't gotten to it yet.
FreezB11 commentedon Oct 10, 2025
hey there would love to join in to help, i was curious in what way do you need the string identifier to work
as is it something for the user side we looking so the code writing and reading is easy or internal handling ?
andrewfurey21 commentedon Oct 12, 2025
With
DAGNetwork, when adding a layer it returns an id (just an index into astd::vector). The idea with this issue is the user may want to use astd::stringinstead. This goes for theFFNandRNNclasses too.FreezB11 commentedon Oct 12, 2025
Ok so I was thinking we can change the multilayer.h file so tht while adding layer to the network one can give name to which can stored in a hashmap and can be accessed also with this hashmap
FreezB11 commentedon Oct 14, 2025
@andrewfurey21 ok so i did some testing with my code and i did get a good thing all the tests pass and no issues with that and all the old code is still compatible just that i have to write a new test for the layer identifiers
@andrewfurey21 can i make a pr so you can review it ??
AshwathElang0 commentedon Mar 26, 2026
@FreezB11 @andrewfurey21 is this issue still open? If no one's taking it up, I'd love to raise a PR and try it myself.
AshishGupta-12 commentedon Jul 26, 2026
Hi is this still open? Saw the messages above from FreezB11 and AshwathElang0 about it. I am interested in trying this if no one's working on it right now.