Repository navigation
Adding min standalone contract for the inventory + removing slot types - #15
Merged
Merged
Conversation
… slot type into the code, not just the interface
ogarciarevett
marked this pull request as draft
October 18, 2023 16:54
Contributor
Author
|
Still on progress, fixing the compiler issues |
ogarciarevett
marked this pull request as ready for review
October 23, 2023 21:53
Contributor
Author
|
The Tests and the CI improvements will be in a different PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slot types kind by a little bit confusing for newbies inventories, so, I'll be removing that functionallity for the InventoryFacet and adding that funcs to an "extension" - different PR