Skip to content

Add psd_args parameter to mne.preprocessing.ICA.plot_sources #12905

Closed

Description

@scholzri

Describe the new feature or enhancement

Add a psd_args parameter to mne.preprocessing.ICA.plot_sources that gets passed to the plot we get when clicking on an IC source name. This would allow customization of the PSD plot that appears when interacting with the plot_sources output, similar to how psd_args works in mne.preprocessing.ICA.plot_components.

Describe your proposed implementation

The implementation would pass the psd_args parameter through to plot_properties when a user clicks on a source name in the plot_sources output.

Describe possible alternatives

I think the proposed implementation is optimal and superior compared to for example creating a new method.

It maintains consistency with how plot_components handles psd_args
It provides immediate, intuitive access to PSD customization within the plot_sources method
It doesn't require additional methods or global configurations, keeping the API simple and flexible

Additional context

No response

Activity

  1. welcome commented on Oct 21, 2024

    @welcome

    Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴

  2. larsoner commented on Oct 21, 2024

    @larsoner
    Member

    Seems straightforward and useful, feel free to open a PR if you're up for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions