Skip to content

Revert change to sphere="auto" - #13405

Merged
larsoner merged 1 commit into
mne-tools:mainfrom
wmvanvliet:revert
Sep 3, 2025
Merged

larsoner merged 1 commit into
mne-tools:mainfrom
wmvanvliet:revert

Conversation

@wmvanvliet

Copy link
Copy Markdown
Contributor

Revert the change in default behavior when sphere="auto" from #13400

@larsoner

larsoner commented Sep 2, 2025

Copy link
Copy Markdown
Member

Should we add support for an mode="robust" or something that does what you originally proposed? That way people can get the enhanced functionality if they want

@wmvanvliet

wmvanvliet commented Sep 2, 2025 •

Copy link
Copy Markdown
Contributor Author

Nah, this is for edge cases anyway, and for that being able to set sphere to anything you want is good enough IMO. The previous change to "auto" was to make it "just work" for a little more cases. But it's not worth breaking someones maxfilter or fieldlines plot over.

@larsoner
larsoner merged commit 07a63fd into mne-tools:main Sep 3, 2025
33 of 34 checks passed
@wmvanvliet
wmvanvliet deleted the revert branch July 26, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants