Repository navigation
integration-cli: retry Windows npipe connect EOF in TestRunTwoConcurrentContainers - #53395
Open
VedantMadane wants to merge 1 commit into
Open
VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
TestRunTwoConcurrentContainers flakes on Windows when concurrent docker CLI processes dial //./pipe/docker_engine and one create hits a transient connect-time EOF under CI load. Retry only that specific error-during-connect + EOF failure so the test still exercises concurrent container starts without failing on the known named-pipe transport flake. Signed-off-by: VedantMadane <[email protected]>
VedantMadane
force-pushed
the
fix/53343-flaky-TestRunTwoConcurrentContainers
branch
from
August 18, 2026 08:56
435c91d to
35af8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens flaky
TestDockerCLIRunSuite/TestRunTwoConcurrentContainerson Windows.Failure
On windows-2022 CI, one of two concurrent
docker runcalls intermittently fails with:Exit code 125 after ~60s. Same class of Windows named-pipe transport flake as #49348 / #53269 (concurrent engine API traffic over
//./pipe/docker_engineunder CI load).Fix
Keep the concurrent launches (that is what this test covers). Retry each
docker runup to 3 times only when the error matches the transient connect EOF pattern (error during connect+EOF). All other failures still fail the test immediately.Residual risk
Fixes #53343
Test plan
TestDockerCLIRunSuite/TestRunTwoConcurrentContainers