Repository navigation
refactor: rename readBody to readErrorBody and cap body size - #1246
Merged
Merged
Conversation
The helper introduced in #1241 is only called on the error path of upstream HTTP responses, so the more specific name makes its intent unambiguous at the call site and prevents accidental reuse on the success path (where streaming JSON decoding is preferred). Wrap the read with io.LimitReader so a misbehaving upstream returning a huge body cannot cause us to buffer it all in memory just to format an error message. 8 KiB is well above any realistic GitHub or JWKS error response.
rdimitrov
enabled auto-merge (squash)
May 4, 2026 11:09
rdimitrov
disabled auto-merge
May 4, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1241. Two small tweaks to the
readBodyhelper:readBody→readErrorBody. The helper is only ever called on the error path (after a non-2xx status check), where we want a small string for diagnostics. The generic name made it look reusable on the success path, where streaming JSON decoding is the right approach. The new name pins the intended use down.io.LimitReader(8 KiB). Defense in depth — error diagnostics never need more than a few KB, and we shouldn't buffer an arbitrarily large body from an upstream just to format an error message. 8 KiB is well above any realistic GitHub API or JWKS error response.No behavior change on the happy path. On the unhappy path, error messages are now bounded.
Test plan
go build ./...go test ./internal/api/handlers/v0/auth/...🤖 Generated with Claude Code