Repository navigation
Improve stdio transport validation and function naming - #365
Merged
Merged
Conversation
- Add validation that URL must be empty for stdio transport types - Rename validateTransport to validateRemoteTransport for clarity - Update test case to expect error when stdio transport has URL This addresses feedback from PR #345 requesting stricter validation for stdio transports and better function naming. :house: Remote-Dev: homespace
Member
Author
|
Requesting review from @rdimitrov |
1 of 9 tasks
jerome3o-anthropic
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateTransporttovalidateRemoteTransportfor better clarityContext
This addresses two specific feedback comments from @domdomegg on PR #345:
The changes enforce stricter validation while improving code readability through better naming.