Skip to content

recoverEmail handler passes action code into the wrong parameter #8299

Description

@Fv7eh

Looks like the recoverEmail path in email-handler.html is passing the action code into the wrong parameter.

handleRecoverEmail is defined as:

function handleRecoverEmail(auth, actionCode, lang) {

But the switch calls it like this:

handleRecoverEmail(actionCode);

Inside the handler, checkActionCode(Auth, actionCode) and applyActionCode(Auth, actionCode) use the second parameter, so actionCode ends up being undefined for recover email links.

How to reproduce:

  1. Open an email recovery link that uses /email-handler?mode=recoverEmail&oobCode=<valid code>.
  2. The handler enters the recoverEmail branch.
  3. handleRecoverEmail receives only one argument.
  4. Firebase receives undefined as the action code, so the email recovery flow fails instead of reverting the email.

Impact is limited, but this does affect account recovery. If a user's email was changed accidentally or maliciously, the recovery link may not work through Monkeytype's handler. I do not think this is account takeover by itself.

A fix would be to either call handleRecoverEmail(Auth, actionCode, lang) or simplify the function signature so the action code is the first argument.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions