Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Commit 5d67d34

Browse files
mattleibowmattleibow
authored
Use the new signing features for RealSigning (#10)
Context: xamarin/yaml-templates#73 > [xamarin/yaml-templates#73] changes things in that nothing is signed > and the nuget-signed artifact no longer gets created. In order to > create that artifact, at least one of he 4 "control" parameters needs > to be set. If you have received approval to RealSign, then you can > add the `realSign` parameter as well. The effect is two changes of consequence vs. bce1b7f & 3fa0c2e: 1. When NuGet packages are signed, a "real" signing certificate will be used, not a "test" signing certificate. (This was the case with Mono.Terminal v5.4.1.) 2. Builds for all tags and master commits are *no longer* signed. Instead, signing is an explicit AzDO operation after the build is complete. This ensures manual review & approval of all signed artifacts.
1 parent 3fa0c2e commit 5d67d34

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

‎.ci/azure-pipelines.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,6 @@ jobs:
3838
- template: sign-artifacts/jobs/v1.yml@internal-templates
3939
parameters:
4040
dependsOn: [ 'build' ]
41+
realSign: true
42+
signTags: true
43+
signMain: true

‎LineEditor/LineEditor.csproj‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<PackageId>Mono.Terminal</PackageId>
6-
<PackageVersion>5.4.1</PackageVersion>
6+
<PackageVersion>5.4.2</PackageVersion>
77
<Authors>Microsoft</Authors>
88
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
99
<PackageIconUrl>https://github.com/mono/LineEditor/raw/master/icon_128x128.png</PackageIconUrl>
1010
<PackageLicenseUrl>https://github.com/mono/LineEditor/blob/master/LICENSE</PackageLicenseUrl>
1111
<Owners>Xamarin</Owners>
1212
<PackageProjectUrl>https://github.com/mono/LineEditor</PackageProjectUrl>
13-
<PackageReleaseNotes>Release 5.4.1 improves Windows support.</PackageReleaseNotes>
13+
<PackageReleaseNotes>Release 5.4.2 improves Windows support.</PackageReleaseNotes>
1414
<PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance>
1515
<Summary>An interactive commmand line editor</Summary>
1616
<Title>Mono.Terminal - LineEdit, GetLine</Title>
@@ -24,7 +24,9 @@
2424
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
2525
<DocumentationFile>bin\Debug\netstandard2.0\LineEditor.xml</DocumentationFile>
2626
</PropertyGroup>
27+
2728
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
2829
<DocumentationFile>bin\Release\netstandard2.0\LineEditor.xml</DocumentationFile>
2930
</PropertyGroup>
31+
3032
</Project>

0 commit comments

Comments
 (0)