This repository was archived by the owner on Sep 25, 2026. It is now read-only.
Repository navigation
Revert "Upgrade linker TFM to net6.0 (#1996)" - #2000
Merged
Merged
Conversation
This reverts commit bf37b29.
marek-safar
approved these changes
Apr 28, 2021
marek-safar
left a comment
marek-safar
left a comment
Contributor
There was a problem hiding this comment.
Is it worth backporting the API changes to P4 so we don't have to wait till July for this to land?
Member
Author
|
We would still have to wait at least 1 month. I'll try to work around this in the linker - it's basically just an enum value - we can just use raw numbers in the worst case. |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
…nker#2000) This reverts commit dotnet/linker@bf37b29. Commit migrated from dotnet/linker@e48f540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit bf37b29.
I intentionally kept the new version of SDK in the repo - we need at least P4 anyway due to tests added for APIs added in that release. Ideally we would keep the SDK in sync with dotnet/runtime, but that really hard to do if linker needs to react to API changes in the runtime repo.