Trailing slash added to urls in href when using linkedom #980

Activity

1. gijsk commented on Sep 24, 2025

   

   gijsk

   on Sep 24, 2025

   Contributor

   More actions

   @richardklapac Does the same issue occur when using jsdom? I cannot reproduce when using jsdom, so I suspect this is a linkedom bug. If it's straightforward enough, I would take a patch that avoids this somehow, but to do that we'd need to know what exactly linkedom is doing and where readability is tripping up.

   generates an object with the href url having a newly added trailing slash

   To be clear, you're saying that the output in this case has a element's href manipulated?
2. richardklapac commented on Sep 26, 2025

   

   richardklapac

   on Sep 26, 2025

   Author

   More actions

   I can't use jsdom at the moment, as the project is not in Node. If we can't pinpoint the linkedom/readability cause, I'll try to reproduce in a Node environment with jsdom as well. In the meantime:

   Yes, it seems that the a element's href is manipulated.

   Here is my minimal code, using the example provided:

   const html = `<!DOCTYPE HTML">
   <html>
   <body>
   <a href="/api/browser/proxy?url=https%3A%2F%2Fwww.debian.org%2Fsecurity%2Ffaq">https://www.debian.org/security/faq</a>
   </body>
   </html>
   `
   console.log(html) // contains correct /faq without a trailing slash
   
   const parser = new DOMParser();
   const doc = parser.parseFromString(html, 'text/html');
   
   console.log(doc.getElementsByTagName("a")[0]) // contains correct /faq without a trailing slash
   
   console.log(new Readability(doc).parse()!.content) // contains incorrect /faq/ with a trailing slash

   First log output is the example HTML.

   Second log output, sorry for the screenshot, React Native devs had the bright idea to force all logs to go through chrome, not cli, and I have no idea how to copy the raw value:

   

   Third log output:

   <DIV class="page" id="readability-page-1">
   <a href="/api/browser/proxy?url=https%3A%2F%2Fwww.debian.org%2Fsecurity%2Ffaq%2F">https://www.debian.org/security/faq</a>
   </DIV>
   
3. gijsk

   changed the title [-]Trailing slash added to urls in href[/-] [+]Trailing slash added to urls in href when using linkedom[/+] on Oct 3, 2025