Repository navigation
Fix test failures introduced by #1086 #1091
Description
Activity
@alexle0nte are you going to work on this?
Yes, I'll create a PR to fix all the tests
@alexle0nte are you making progress on this?
@marco-c Yes, #1125 fixes all the metrics tests.
However, there is a problem with repository tests, whose snapshots are contained inrca-output.Version
0.21.2oftree-sitter-rusthas a bug regarding parsing doc comments, that causes manyserdetests to fail.
This bug has been fixed in version0.23.0, however, upgradingtree-sitter-rustto this version would also require upgrading all other grammars to0.23.0, buttree-sitter-kotlindoesn't yet supporttree-sitter 0.23.0.In the meantime, I could update the snapshots of all the files that don't contain doc comments, and then, when version
0.23.0oftree-sitter-kotlinis released, we can do a new grammar upgrade and update the remaining snapshots as well.@alexle0nte do you think we could submit a PR to tree-sitter-kotlin to support 0.23.0 or is it hard?
Your plan seems fine otherwise.
@marco-c I've just opened a PR in
tree-sitter-kotlinto bump thetree-sitterdependency to23.0. Once it's merged and the new release is out, we can upgrade all the grammars to23.0.Thanks! If it still open in a couple of week, we could create a temporary fork to unblock the updates.
Reacted by Alex@marco-c and @alexle0nte
We can also ask
tree-sitterdevelopers if they are willing to adopt theKotlingrammar among their organization's parsers@Luni-4 @alexle0nte it looks like the PR is still not merged, wdyt we should do?
@Luni-4 @alexle0nte it looks like the PR is still not merged, wdyt we should do?
I think we can create a temporary fork as you suggested and use that until it gets merged
We can close this now, right @alexle0nte ?
We can close this now, right @alexle0nte ?
Yes
