Skip to content

Permalinks on Evolution dashboard do not retain selected aggregates for categorical histogram #395

Open

Description

@mreid-moz

STR:

  1. visit this permalink
  2. un-select "eOK" key and instead select "eTooLate"
  3. generate a new permalink
  4. load the new permalink
  5. Observe selected keys (it reverts to "eOK" for me).

Activity

  1. self-assigned this
    on Feb 13, 2018
  2. changed the title [-]Permalinks on Evolution dashboard do not retain selected keys for keyed histogram[/-] [+]Permalinks on Evolution dashboard do not retain selected aggregates for categorical histogram[/+] on Feb 13, 2018
  3. chutten commented on Feb 13, 2018

    @chutten
    Contributor

    Probably fallout from #377 where I reworked how we load and change measures in the evo dashboard.

  4. ab0092 commented on Feb 23, 2018

    @ab0092
    Contributor

    @chutten i have gone through the issue and i think the selected aggregate type is not part of the url which is used to restore state of the page. Is it something you are working on or shall i work on this issue

  5. o0Ignition0o commented on Feb 25, 2018

    @o0Ignition0o
    Collaborator

    It seems like the aggregates are part of the url, eg : "http://0.0.0.0:8000/new-pipeline/evo.html#!aggregates=0!4" but they don't get parsed the right way.

    I also don't get what's going on here, it seems like the aggregates key have nothing to do with the applicable values.

    This is pretty weird indeed ! :)

    I should probably also file a (maybe) followup bug because it seems like I have to click on the aggregate selector twice before it selects anything O_o

  6. chutten commented on Feb 26, 2018

    @chutten
    Contributor

    Oh geez, the aggregates are saved to the URL using their index? That's... probably "mostly fine" but certainly isn't parsed that way.

  7. removed their assignment
    on Feb 26, 2018
  8. gargshruti30 commented on Mar 21, 2018

    @gargshruti30
    Contributor

    @chutten @georgf Can I work on this issue ?

  9. chutten commented on Mar 21, 2018

    @chutten
    Contributor

    Yes you may. It might prove tricky. You may want to start by looking at #404 and at the code in loadStateFromUrlAndCookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions