Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: msgpack/msgpack-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8.4
Choose a base ref
...
head repository: msgpack/msgpack-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.8.5
Choose a head ref
  • 13 commits
  • 11 files changed
  • 7 contributors

Commits on Aug 6, 2026

  1. Fix some Factory/ext_type optimization edge cases

    Previously, optimized_symbol_parsing would enable a fast path for
    symbols but it never actually registered the Symbol's ext_type (so it
    was always 0x0). This resulted in the optimization not working if Symbol
    is registered with a different type and could additionally cause data
    corruption if some other type is registered as 0x0.
    
    Additionally, many of these Factory fields were not copied over on dup,
    meaning pooled Factories would have optimized_symbol_parsing disabled if
    they don't explicitly `freeze` before calling `pool` (which would do
    `dup.freeze`).
    skipkayhil committed Aug 6, 2026
    Configuration menu
    Copy the full SHA
    0c5583c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #400 from Shopify/hm-nvplsywlxruxzzmx

    Fix some Factory/ext_type optimization edge cases
    byroot authored Aug 6, 2026
    Configuration menu
    Copy the full SHA
    64fca29 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2026

  1. Configuration menu
    Copy the full SHA
    5d55d7e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #402 from msgpack/gc-guard

    Packer_write_extension: guard on string being moved
    byroot authored Aug 8, 2026
    Configuration menu
    Copy the full SHA
    8c429cd View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2026

  1. Configuration menu
    Copy the full SHA
    c3d1c61 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2026

  1. Consume nil in Unpacker#skip_nil

    Co-Authored-By: Jean Boussier <[email protected]>
    OskarEichler and byroot committed Aug 30, 2026
    Configuration menu
    Copy the full SHA
    512b587 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #404 from OskarEichler/audit/consume-skip-nil

    Consume cached nil in Unpacker#skip_nil
    byroot authored Aug 30, 2026
    Configuration menu
    Copy the full SHA
    663c3a3 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #403 from OskarEichler/audit/factory-registration-…

    …edge-cases
    
    Fix Factory registration edge cases
    byroot authored Aug 30, 2026
    Configuration menu
    Copy the full SHA
    29d98d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2026

  1. Fix SEGV on stack depth underflow in recursive extension unpacking

    A recursive extension proc that rescues an inner read error, or that
    calls Unpacker#skip, drives stack.depth down to 0 before
    read_raw_body_begin pops the barrier it pushed. The unconditional pop
    then underflowed depth to SIZE_MAX and read/wrote out-of-bounds stack
    entries, crashing the VM. Restore the depth to just below the pushed
    barrier instead of decrementing unconditionally.
    
    Co-Authored-By: Claude Opus 4.8 <[email protected]>
    Watson1978 and claude committed Sep 3, 2026
    Configuration menu
    Copy the full SHA
    7ff80ad View commit details
    Browse the repository at this point in the history
  2. Merge pull request #405 from Watson1978/fix/recursive-ext-stack-under…

    …flow
    
    Fix SEGV on stack depth underflow in recursive extension unpacking
    byroot authored Sep 3, 2026
    Configuration menu
    Copy the full SHA
    4e2a755 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2026

  1. Guard packerProc against a missing :packer key on JRuby

    RubyHash#fastARef returns Java null for an absent key, so registering a
    Symbol type with only an :unpacker raised NullPointerException.
    ExtensionEntry.hasPacker already guards the same value this way.
    youdie006 committed Sep 11, 2026
    Configuration menu
    Copy the full SHA
    72cda9b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #406 from youdie006/symbol-unpacker-only-npe

    Guard packerProc against a missing :packer key on JRuby
    byroot authored Sep 11, 2026
    Configuration menu
    Copy the full SHA
    db16d5d View commit details
    Browse the repository at this point in the history
  3. Release 1.8.5

    byroot committed Sep 11, 2026
    Configuration menu
    Copy the full SHA
    972321a View commit details
    Browse the repository at this point in the history
Loading