fix(catalog): reject empty refresh response in native shell (parity with #101) - #108
Merged
Merged
Conversation
…rity with #101) Native parity follow-up to Arvuno's Tauri fix (#101): when a catalog refresh parses to a valid-but-empty JSON array, throw `CatalogRefreshError.emptyResponse` BEFORE persisting or swapping the in-memory catalog, so a hostile mirror / partial body / CDN error page can't silently zero out the user's catalog. The guard sits before gzip/write, so a rejected refresh keeps the previous good catalog — mirroring the Tauri `refresh_catalog_inner` guard exactly. Safe on every OS: cask.json comes from the formulae.brew.sh API, not the OS-gated local brew layer, so it's non-empty regardless of platform. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native-shell parity for @Arvuno's Tauri fix (#101).
When a catalog refresh parses to a valid but empty JSON array, the native
CatalogService.refresh()now throwsCatalogRefreshError.emptyResponsebefore gzip/persist/in-memory-swap — so a hostile mirror, a partial body, or a CDN error page that happens to be an empty JSON array can't silently zero out the user's catalog. A rejected refresh keeps the previous good catalog, mirroring the Taurirefresh_catalog_innerguard exactly.Safe on every OS:
cask.jsoncomes from theformulae.brew.shAPI, not the OS-gated local brew layer, so it's non-empty regardless of platform.Build: green.
🤖 Generated with Claude Code