fix(native): Outdated filter drops tap-installed packages (tap-name mismatch) - #145
Merged
Merged
Conversation
…ismatch) Native tagged Library rows "outdated" by matching the installed token against the `brew outdated` name set with a plain Set.contains. But `brew outdated` reports tap formulae fully-qualified (`shivammathur/php/[email protected]`) while `brew info --installed` — the row source — reports the bare token (`[email protected]`), so tap-installed outdated packages never matched: they vanished from the Outdated filter and lost their outdated dot. Symptom: Swift's Outdated count read one short of Tauri's (8 vs 9) whenever a tapped formula was outdated. Normalise both sides through `bareToken` (the same last-segment rule the #92 install matching already uses). Regression test covers the tap-qualified match plus the bare-name non-regression. swift 174 (+1). Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01X9iMFjHE21ePTjcbHpTXt6
# Conflicts: # native/Sources/BrewBrowserKit/AppModel.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native's Outdated count read one short of Tauri's (8 vs 9) whenever a tap-installed formula was outdated.
brew outdatedreports tap formulae fully-qualified (shivammathur/php/[email protected]) whilebrew info --installed— the Library row source — reports the bare token ([email protected]). Native matched the raw name sets, so tap-installed outdated packages were silently dropped from the Outdated filter and their outdated dot.Normalize both sides through
bareToken(the same last-segment rule the #92 install matching uses). Regression test covers the tap-qualified match + bare-name non-regression. Native-only. swift 174.🤖 Generated with Claude Code
https://claude.ai/code/session_01X9iMFjHE21ePTjcbHpTXt6