fix: native Keychain-prompt parity + Linuxbrew PATH (follow-up to #152) - #155
Merged
Merged
Conversation
Two gaps left after #152 (@fallenmaverick), which fixed the Tauri app: 1. Native Keychain prompt parity. #152 gated the Tauri app's eager startup GitHub-status read behind a localStorage "signed-in" flag so users who never use GitHub get no macOS Keychain prompt on launch. The native app had the same eager read (ContentView `.task { loadGithubStatus() }`). Add a UserDefaults hint `brew-browser:github:signed-in` (set on any signed-in status read + on device-flow sign-in), and gate the startup task on it — mirroring the Tauri behavior exactly. 2. Linuxbrew PATH. #152's PATH prepend covered macOS `/opt/homebrew` + `/usr/local` but not Linuxbrew; add `/home/linuxbrew/.linuxbrew/{bin,sbin}` so GUI-launched Linux builds resolve brew subcommands (git, openssl, …). Non-existent prefixes per host are harmless. Gate: native swift build + 199 tests · Rust build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01X9iMFjHE21ePTjcbHpTXt6
Contributor
|
Absolutely loved the app by the way 👌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #152 (@fallenmaverick) — closes the two parity/coverage gaps that PR left open, keeping both shells and all three platforms consistent.
1. Native Keychain-prompt parity
#152 gated the Tauri app's eager startup GitHub-status read behind a
localStoragebrew-browser:github:signed-inflag, so users who never touch GitHub get no macOS Keychain prompt on launch. The native app had the identical eager read (ContentView.swift→.task { await model.loadGithubStatus() }). This adds aUserDefaultshint of the same name — set on any signed-in status read and on device-flow sign-in — and gates the startup task on it. Mirrors the Tauri behavior exactly: sign-in sets the hint, so the first post-sign-in launch (and every one after) reads status; a never-signed-in user's launch never touches the Keychain.2. Linuxbrew PATH
#152's PATH prepend in
brew/exec.rscovered macOS/opt/homebrew(Apple Silicon) +/usr/local(Intel) but not Linuxbrew. Adds/home/linuxbrew/.linuxbrew/{bin,sbin}so GUI-launched Linux builds resolve brew subcommands (git, openssl, …). Non-existent prefixes on a given host are harmless.Testing
swift build+ 199 tests passThanks @fallenmaverick — this rides on top of your #152.
🤖 Generated with Claude Code
https://claude.ai/code/session_01X9iMFjHE21ePTjcbHpTXt6