Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Allow line ending conversions to be set in Inno Setup INF file #165

Description

@n8felton

Currently it does not appear that you can set the preferred line ending conversion via the INF file for the Inno Setup to be used with the /VERYSILENT and /LOADINF arguments. I would like to see this implemented as we would like to be able to silently deploy git with the "as-is/as-is" option.

Activity

  1. dscho commented on Feb 17, 2014

    @dscho
    Member

    @n8felton from my quick search, we have no support for the /LOADINF argument so far. Care to add it? We'll release 1.9 today or tomorrow, might be cutting it close, but if you make it until then, I'd be happy to accept a pull request!

  2. added a commit that references this issue on Feb 18, 2014
    2e6ffcd
  3. n8felton commented on Feb 18, 2014

    @n8felton
    ContributorAuthor

    This was easier to implement than I had originally thought. 👍

  4. added 7 commits that reference this issue on Feb 18, 2014
    1a98e83
    b518955
    8d25950
    23c4dc3
    d30295f
    f5f991e
    b53b404
  5. mathrick commented on Feb 23, 2014

    @mathrick

    Could you push out an installer build with that patch in? It's absolutely crucial for silent installs to be able to get git.exe in the PATH, and that's currently not possible with any installer available. I've just discovered that fact and it's completely wrecking my plan of making a single-click deployment script that gets all the tools set up on Windows.

    I understand if you don't want to push out a new git version, but just the installer functionality itself warrants posting a new build, and is fairly trivial to test.

  6. dscho commented on Feb 23, 2014

    @dscho
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions