Repository navigation
fix: add missing ft_metadata view function to fungible token example - #428
Open
tenderdeve wants to merge 1 commit into
Open
tenderdeve wants to merge 1 commit into
tenderdeve wants to merge 1 commit into
Conversation
The my-ft example defines and stores FungibleTokenMetadata but never exposes it via a view function, violating NEP-148. Add ft_metadata() and implement FungibleTokenMetadataProvider, matching the pattern used by the NFT example. Fixes near#415
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
my-ftexample defines and storesFungibleTokenMetadatabut never exposes it via a view function, violating NEP-148ft_metadata()view function and implementFungibleTokenMetadataProviderinterfacemy-nft.tsline 173)File:
examples/src/fungible-token/my-ft.tsFixes #415
Test plan
pnpm buildft_metadataon a deployed instance — should return the metadata object