Skip to content

Don't throw when we are deleting nothing - #94

Merged
nickvergessen merged 1 commit into
masterfrom
issue-2688-error-on-empty-activity-mail-deletion
Dec 19, 2016
Merged

Don't throw when we are deleting nothing#94
nickvergessen merged 1 commit into
masterfrom
issue-2688-error-on-empty-activity-mail-deletion

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Dec 15, 2016

Copy link
Copy Markdown
Member

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Dec 15, 2016
This was referenced Dec 15, 2016
Closed
Closed
@LukasReschke

LukasReschke commented Dec 16, 2016

Copy link
Copy Markdown
Member

We should probably backport this, right?

@nickvergessen
nickvergessen merged commit f83a0d7 into master Dec 19, 2016
@nickvergessen
nickvergessen deleted the issue-2688-error-on-empty-activity-mail-deletion branch December 19, 2016 09:09
@nickvergessen nickvergessen mentioned this pull request Dec 19, 2016
Merged
@nickvergessen

nickvergessen commented Dec 19, 2016

Copy link
Copy Markdown
Member Author

Yes, backport is in #95

@enoch85 enoch85 mentioned this pull request Dec 29, 2016
Closed
@tflidd

tflidd commented Jan 1, 2017

Copy link
Copy Markdown

backport for NC 10 as well? https://help.nextcloud.com/t/email-notification-does-not-work-error-in-logging-file/6928

@nickvergessen

nickvergessen commented Jan 4, 2017

Copy link
Copy Markdown
Member Author

Right, we backported the previous change: #54
So yes need to backport this to 10 as well

@nickvergessen nickvergessen mentioned this pull request Jan 4, 2017
Merged
@nickvergessen

nickvergessen commented Jan 4, 2017

Copy link
Copy Markdown
Member Author

Done in #99

@JSoko

JSoko commented Jan 12, 2017

Copy link
Copy Markdown
Member

It seems that this fix isn't included in 11.0.1 RC1

@techc0de

techc0de commented Jan 12, 2017 •
edited
Loading

Copy link
Copy Markdown

I'm using external storage without encryption, and I still having this errors.
The mp3/videos aren't play either while connect remotely.
This error didn't exist in NC10.

`imagecreatefromstring(): Empty string or invalid image at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/legacy/image.php#597

fclose() expects parameter 1 to be resource, boolean given at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#218

fread() expects parameter 1 to be resource, boolean given at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#217

fopen(/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg): failed to open stream: No such file or directory at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#216

filesize(): stat failed for /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#211

fopen(/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg): failed to open stream: No such file or directory at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#216


 filesize(): stat failed for /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/data/tien/files/media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/core/img/filetypes/audio.svg at /media/54bf67db-da31-4c50-bb3c-27140944b223/www/nextcloud/lib/private/Files/Storage/Local.php#211`

@nickvergessen

nickvergessen commented Jan 12, 2017

Copy link
Copy Markdown
Member Author

Yeah, I merged it on the day after. But Should be included in RC2 (when we do one) or the final.

@techc0de

techc0de commented Jan 12, 2017

Copy link
Copy Markdown

Looking forward to it.
Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

Assignees

No one assigned

Labels

3. to review bug feature: email

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @LukasReschke @tflidd @JSoko @techc0de