NPE: java.lang.NullPointerException: Attempt to invoke virtual method 'long java.lang.Long.longValue()' on a null object reference #13502

Activity

1. wrenix

   added

   bug

   on Sep 2, 2024
2. wrenix

   changed the title [-]NullPointer in Details[/-] [+]NullPointer in open Details[/+] on Sep 2, 2024
3. joshtrichards

   added

   stable-3.30

   performance: NPE 🚫NullPointerException / Null Pointer ExceptionNullPointerException / Null Pointer Exception

   on Sep 2, 2024
4. sujan6539 commented on Sep 3, 2024

   

   sujan6539

   on Sep 3, 2024

   Last edited by sujan6539

   More actions

   The issue seems to originate from the FileEntity.getInternalTwoWaySync which is nullable, and there might be cases when it is actually null. The getter mentioned above is responsible for setting the internal folder sync timestamp using setInternalFolderSyncTimestamp in the manager. I prefer to change implementation of setInternalFolderSyncTimestamp in OCFile.java to set to default if a new time stamp is null for any future null setter.

   I can work on it if you are satisfied with my response!
5. WarpinWolf commented on Sep 4, 2024

   

   WarpinWolf

   on Sep 4, 2024

   More actions

   Not sure whether I'm allowed/whether it makes sense to add:

   • I open folder A in App.
   • I select one file.
   • I chose copy/move.
   • I select target folder B / copy.
   • I am back in the folder A.
   • I click on next file (ODF) in A -> Null Pointer

   Cause of error

   Exception in thread "main" java.lang.NullPointerException: Attempt to invoke virtual method 'long java.lang.Long.longValue()' on a null object reference
       at com.owncloud.android.datamodel.OCFile.isInternalFolderSync(OCFile.java:1058)
       at com.owncloud.android.datamodel.FileDataStorageManager.isPartOfInternalTwoWaySync(FileDataStorageManager.java:2504)
       at com.owncloud.android.ui.fragment.FileDetailFragment.updateFileDetails(FileDetailFragment.java:572)
       at com.owncloud.android.ui.fragment.FileDetailFragment.onViewCreated(FileDetailFragment.java:266)
       at androidx.fragment.app.Fragment.performViewCreated(Fragment.java:3152)
       at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:608)
       at androidx.fragment.app.FragmentStateManager.moveToExpectedState(FragmentStateManager.java:286)
       at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:2164)
       at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:2059)
       at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:2002)
       at androidx.fragment.app.FragmentManager$5.run(FragmentManager.java:702)
       at android.os.Handler.handleCallback(Handler.java:958)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:205)
       at android.os.Looper.loop(Looper.java:294)
       at android.app.ActivityThread.main(ActivityThread.java:8225)
       at java.lang.reflect.Method.invoke(Native Method)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:573)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1058)

   App information

   • ID: com.nextcloud.android.beta
   • Version: 20240827
   • Build flavor: versionDev

   Device information

   • Brand: AGM
   • Device: AGM_PAD_P2
   • Model: AGM_PAD_P2
   • Id: UP1A.231005.007
   • Product: AGM_PAD_P2_EU

   Firmware

   • SDK: 34
   • Release: 14
   • Incremental: 265180
6. joshtrichards

   added

   feature: files

   on Sep 13, 2024
7. joshtrichards

   changed the title [-]NullPointer in open Details[/-] [+]NullPointer in open Details: `java.lang.NullPointerException: Attempt to invoke virtual method 'long java.lang.Long.longValue()' on a null object reference`[/+] on Sep 22, 2024
8. joshtrichards

   added

   regression

   on Sep 22, 2024
9. joshtrichards

   changed the title [-]NullPointer in open Details: `java.lang.NullPointerException: Attempt to invoke virtual method 'long java.lang.Long.longValue()' on a null object reference`[/-] [+]NPE: `java.lang.NullPointerException: Attempt to invoke virtual method 'long java.lang.Long.longValue()' on a null object reference`[/+] on Sep 22, 2024
10. alperozturk96

    self-assigned this

    on Sep 23, 2024
11. alperozturk96 commented on Sep 24, 2024

    

    alperozturk96

    on Sep 24, 2024

    Collaborator

    More actions

    Thanks for the report. Could you try with this PR: #13612 ?
12. alperozturk96

    linked a pull request that will close this issueBugFix - NPE internalFolderSyncTimestamp & File Existence Check #13612on Sep 24, 2024
13. mrwsl commented on Sep 24, 2024

    

    mrwsl

    on Sep 24, 2024

    More actions

    I downloaded the app and can confirm that the PR is working for me.
14. CarlosCastaneda commented on Sep 24, 2024

    

    CarlosCastaneda

    on Sep 24, 2024

    More actions

    The same to me #13608, working as expected👍
15. tobiasKaminsky

    closed this as completedin #13612on Oct 4, 2024
16. joshtrichards

    pinned this issue on Oct 7, 2024
17. joshtrichards

    unpinned this issue on Oct 18, 2024