[Theming] Dynamically use server color by tobiasKaminsky · Pull Request #1031 · nextcloud/android

tobiasKaminsky · 2017-05-22T09:51:22Z

This overwrites the default server color and uses the color provided via theming app.

TODO:

OPEN / UNRESOLVED:

change color of main FAB button -> currently not supported in library
toolbar: changed only after restart or entering and leaving multiselect
UploadFilesActivity: "select all" in overflow menu: not colored and wrong icon(?!)
ShareDialog: theming header of DatePicker not possible, only with https://github.com/wdullaer/MaterialDateTimePicker
AutoUpload: uploadBehaviour: bullet points of dialog. Canntot use theme: Caused by: java.lang.IllegalStateException: This Activity already has an action bar supplied by the window decor.
SwitchPreference not possible

auto upload cloud icon in on state: tint it

…rTheming

tobiasKaminsky · 2017-05-22T11:30:19Z

In theming app on server we only define one basic color.
But in android we use some more:

primary
primary dark
color accent

How can we get these colors? color accent is a bit lighter, the other one darker.
Shall this be auto-generated? If so, how? As I am not a designer something rgb transformation rule would be nice.

AndyScherzinger · 2017-05-22T12:15:17Z

use background image for drawer (do we need a scaled version for this?)
- definitely, that is why right now we ship a scaled version, since letting Android OS scale the original image at runtime is a real performance killer (drawer open/close starts to hang...!)
handle background color for drawer (if image in theming app is disabled)
- this is either primary or primary dark at the moment

How can we get these colors?

We are more or less free to choose how they get calculated since they do not really follow Material Design guidelines (simply since we do not use a truly different accent color but a slightly lighter one). Maybe @juliushaertl has an idea on color calculation here since he is the server side color calculation hero 😃

juliusknorr · 2017-05-22T17:56:12Z

We are more or less free to choose how they get calculated since they do not really follow Material Design guidelines (simply since we do not use a truly different accent color but a slightly lighter one). Maybe @juliushaertl has an idea on color calculation here since he is the server side color calculation hero

It should work quite well if you convert the RGB value to the HSL color space and then either increase or decrease the lightness (L) component to get brighter/darker color tones.

Unfortunately android sdk doesn't seem to support HSL out of the box or at least I can't find it at the moment. But conversion is not that hard, see: https://tips4java.wordpress.com/2009/07/05/hsl-color/

AndyScherzinger · 2017-05-24T10:58:16Z

primary_dark should be the fallback for drawer and user info screen background image in case no background image could be retrieved from server

tobiasKaminsky · 2017-05-24T15:09:57Z

@juliushaertl thanks for pointing out with HSL.
There is a native way with ColorUtils; currently I am testing with +/- 0.2 for L.

tobiasKaminsky · 2017-07-11T05:50:37Z

The bullet points are now grey as discussed as we cannot dynamically theme them.

AndyScherzinger · 2017-07-11T07:10:10Z

regarding colored links in participate view: which language do you use? The strings need to be changed on transifex, and I can only do this for en-us (the default) in github, so en-gb and german will not work currently.

@tobiasKaminsky than I guess that is the reason for it since I run English (Germany) on my device 😁

…erTheming

AndyScherzinger · 2017-07-11T10:33:47Z

+                int trackColor = Color.argb(77, Color.red(color), Color.green(color), Color.blue(color));
+
+                // setting the thumb color
+                DrawableCompat.setTintList(switchView.getThumbDrawable(), new ColorStateList(


needs an API check since we support 14+ while getThumbDrawable() is v16+

AndyScherzinger · 2017-07-11T10:33:56Z

+                        new int[]{color, Color.WHITE}));
+
+                // setting the track color
+                DrawableCompat.setTintList(switchView.getTrackDrawable(), new ColorStateList(


needs an API check since we support 14+ while getTrackDrawable() is v16+

AndyScherzinger · 2017-07-11T10:37:10Z

Awesome fix @tobiasKaminsky - very minor thing which we can ignore: The settings switches are slightly lighter colored than the "regular ones, see screenshot mix:

tobiasKaminsky · 2017-07-11T10:50:01Z

Feel free to try to set the color to a better value ;-)

AndyScherzinger · 2017-07-11T11:05:54Z

I'll have a look!

AndyScherzinger · 2017-07-11T12:36:32Z

👍 fine with all the changes and by now thoroughly tested on dev releases and also by me - @mario feel free to review/approve/merge :)

juliusknorr · 2017-07-11T21:31:06Z

Great work everyone, works really nice in the dev release 👏

AndyScherzinger · 2017-07-12T10:05:22Z

@mario @tobiasKaminsky in case we get this merged today I' might be able to update the auto upload branch this evening if there aren't too many conflicts to resolve. :D

mario · 2017-07-12T22:14:08Z

@AndyScherzinger if you feel like this is ok, feel free to merge - I will not be able to review it in a while. Thanks.

…erTheming

AndyScherzinger · 2017-07-13T10:03:19Z

👍 Updated to latest master and ran a final test 👍

tobiasKaminsky added 6 commits May 21, 2017 12:43

WIP use colors from setup.xml for folder icons

56b0370

tint checkboxes

5bfc3db

unify tintDrawable methods

ca49e55

change auto upload cloud icon

a07b049

checkbox in off state: grey

876a7d2

auto upload cloud icon in on state: tint it

add server name & color

1016d25

tobiasKaminsky added the 2. developing label May 22, 2017

tobiasKaminsky added 2 commits May 22, 2017 13:15

removed navigation bar color and set to primary

0092d53

Merge remote-tracking branch 'remotes/origin/colorFolderNew' into use…

bcdcc11

…rTheming

AndyScherzinger added the needs info Waiting for info from user(s). Issues with this label will auto-stale. label May 22, 2017

tobiasKaminsky added 2 commits May 22, 2017 14:57

use background image from theming app in drawer

40c5920

change progress color

6bfeb2c

AndyScherzinger force-pushed the colorFolderNew branch from 5e246f2 to 9b64c2c Compare May 22, 2017 16:02

tobiasKaminsky mentioned this pull request May 22, 2017

Server & Mobil App Theme Color Integration nextcloud/ios#166

Closed

AndyScherzinger force-pushed the colorFolderNew branch 4 times, most recently from 17b227b to 3d772ab Compare May 24, 2017 07:46

tobiasKaminsky mentioned this pull request May 24, 2017

[Branding] Use color for folders, ... #1030

Merged

tobiasKaminsky added 4 commits May 24, 2017 15:49

Merge remote-tracking branch 'remotes/origin/master' into userTheming

5f5430d

use background image also an user info

8c2c900

use server slogan if present when browsing root folder

3950da5

partially color primary and primary_dark working

2bf1cf1

AndyScherzinger force-pushed the colorFolderNew branch from 3d772ab to dc21800 Compare May 26, 2017 09:19

AndyScherzinger force-pushed the userTheming branch from 2bf1cf1 to 4c4c498 Compare May 27, 2017 13:40

tobiasKaminsky added 2 commits July 11, 2017 07:49

use fallback theme to color bullet points of upload behaviour

466772f

remove unnecessary line wraps

2fd5e75

AndyScherzinger and others added 5 commits July 11, 2017 09:25

fix legacy sdk checks for pre-v14 sdks

76779f9

Merge branch 'master' of https://github.com/nextcloud/android into us…

1b64ac7

…erTheming

use darker fallback color

0bd0354

proper licence

3fbe9b8

themeable switch preference

938e222

AndyScherzinger reviewed Jul 11, 2017

View reviewed changes

api check

05985f3

AndyScherzinger added 3. to review and removed 2. developing labels Jul 11, 2017

Merge branch 'master' of https://github.com/nextcloud/android into us…

9ab5338

…erTheming

AndyScherzinger merged commit 8950a4f into master Jul 13, 2017

AndyScherzinger deleted the userTheming branch July 13, 2017 10:04

AndyScherzinger removed 3. to review ready for dev labels Jul 13, 2017

This was referenced Jul 14, 2017

Nextcloud Dev 20170705: "Settings" page for Passlock and "Show hidden files" confusion. #1163

Closed

Theming #920

Closed

hitam4450 mentioned this pull request Aug 31, 2017

Themeing NOT apllied #1471

Closed

Conversation

tobiasKaminsky commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasKaminsky commented May 22, 2017

Uh oh!

AndyScherzinger commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusknorr commented May 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger commented May 24, 2017

Uh oh!

tobiasKaminsky commented May 24, 2017

Uh oh!

tobiasKaminsky commented Jul 11, 2017

Uh oh!

AndyScherzinger commented Jul 11, 2017

Uh oh!

AndyScherzinger Jul 11, 2017

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger Jul 11, 2017

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger commented Jul 11, 2017

Uh oh!

tobiasKaminsky commented Jul 11, 2017

Uh oh!

AndyScherzinger commented Jul 11, 2017

Uh oh!

AndyScherzinger commented Jul 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusknorr commented Jul 11, 2017

Uh oh!

AndyScherzinger commented Jul 12, 2017

Uh oh!

mario commented Jul 12, 2017

Uh oh!

AndyScherzinger commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tobiasKaminsky commented May 22, 2017 •

edited

Loading

AndyScherzinger commented May 22, 2017 •

edited

Loading

juliusknorr commented May 22, 2017 •

edited

Loading

AndyScherzinger commented Jul 11, 2017 •

edited

Loading

AndyScherzinger commented Jul 13, 2017 •

edited

Loading