Skip to content

Catch a rare exception while setting activity list adapter - #1173

Merged
AndyScherzinger merged 2 commits into
masterfrom
ErrorInActivityListAdapter
Jul 16, 2017
Merged

AndyScherzinger merged 2 commits into
masterfrom
ErrorInActivityListAdapter

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

Ref: #1066 (comment)
(although the linked issue is not solved via this)

public static final int ACTIVITY_TYPE = 101;
private final ActivityListInterface activityListInterface;
private final int px;
private static final String TAG = "ActivityListAdapter";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

private static final String TAG = ActivityListAdapter.class.getSimpleName();

@AndyScherzinger

AndyScherzinger commented Jul 11, 2017 •

Copy link
Copy Markdown
Member

馃憤 fine by me

Approved with PullApprove

@mario

mario commented Jul 12, 2017

Copy link
Copy Markdown
Contributor

@AndyScherzinger if you feel like this is ok, feel free to merge - I will not be able to review it in a while. Thanks.

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.5.0 milestone Jul 16, 2017
@AndyScherzinger
AndyScherzinger force-pushed the ErrorInActivityListAdapter branch from 2f2c0cf to 6832fd4 Compare July 16, 2017 13:47
@AndyScherzinger
AndyScherzinger merged commit ab27bc3 into master Jul 16, 2017
@AndyScherzinger
AndyScherzinger deleted the ErrorInActivityListAdapter branch July 16, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants