Repository navigation
Create individual workers for every Autoupload Folder - #13015
Conversation
JonasMayerDev
changed the title
d011ec9 to
49103a7
Compare
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
Signed-off-by: Jonas Mayer <[email protected]>
bbc8743 to
d91b652
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13015.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13015-Screenshot-blue-Light-18-26 |
alperozturk96
left a comment
alperozturk96
left a comment
There was a problem hiding this comment.
Tested. I created 3 folder set auto upload and only 3 worker created for each auto upload and all uploads successfully completed.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
This PR finally gets rid of the foreground worker and the corresponding notification by lowering the chance the worker gets killed.
Internally, the app now starts a new worker for every auto upload folder instead of one worker for all folders.
Advantages are:
The best way to test is using logcat and filtering for "File sync" since all important log messages start with that term. Like this, you should be able to observe the behavior of the background worker without messing with it. If you want to check something specific, use the debugger, but be aware that that changes behavior (like execution speed).