Repository navigation
BugFix - Unnecessary Sync - #13897
Merged
Merged
Conversation
Signed-off-by: alperozturk <[email protected]>
1 task done
1 task done
ZetaTom
approved these changes
Oct 29, 2024
ZetaTom
left a comment
ZetaTom
left a comment
Collaborator
There was a problem hiding this comment.
In my tests, this fixed the endless re-downloading of synchronised folders.
Collaborator
Author
|
/backport to stable-3.30 |
4 tasks done
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regression occurred during the conversion from service to worker. Previously, while using the service, we triggered FileDownloader in a loop for mFilesForDirectDownload. Now, since FileDownloadWorker supports both folder and file sync, we can directly use the mFilesForDirectDownload list with the worker.
How to Test?