Skip to content

Power saving crash - #14002

Merged
tobiasKaminsky merged 3 commits into
masterfrom
powerSavingCrash
Nov 25, 2024
Merged

Power saving crash#14002
tobiasKaminsky merged 3 commits into
masterfrom
powerSavingCrash

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Nov 12, 2024 •
edited by alperozturk96
Loading

Copy link
Copy Markdown
Member

Fix #13404

  • Tests written, or not not needed

alperozturk96
alperozturk96 approved these changes Nov 20, 2024
View reviewed changes

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working

@tobiasKaminsky @alperozturk96
Fix power check dialog
d763717 
added test

Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky @alperozturk96
Fix power check dialog
03b83c4 
added test

Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky @alperozturk96
update screenshots
8512212 
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions

github-actions Bot commented Nov 20, 2024

Copy link
Copy Markdown

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code298298
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total508508

@github-actions

github-actions Bot commented Nov 20, 2024

Copy link
Copy Markdown

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14002-Screenshot-blue-Light-15-37

@tobiasKaminsky
tobiasKaminsky merged commit 287203e into master Nov 25, 2024
@tobiasKaminsky
tobiasKaminsky deleted the powerSavingCrash branch November 25, 2024 13:24
@joshtrichards

joshtrichards commented Dec 28, 2024

Copy link
Copy Markdown
Member

Should we backport this to 3.30.x or is 3.30.6 the end of the line for 3.30.x?

@CodeSteph

CodeSteph commented Jan 2, 2025

Copy link
Copy Markdown

Should we backport this to 3.30.x or is 3.30.6 the end of the line for 3.30.x?

Yes please, this bug is very annoying. Can someone review it ?
It is blocking auto-upload for already selected directories and I haven't found any workaround to reactivate it (deselecting/reselecting, changing config, ...). Manually disabling power saving is not working either, thus, no more auto-upload for me. Please help, I'm convinced many users encounter the same issue

@tobiasKaminsky

tobiasKaminsky commented Jan 3, 2025

Copy link
Copy Markdown
Member Author

Good idea 馃憤

@tobiasKaminsky

tobiasKaminsky commented Jan 3, 2025

Copy link
Copy Markdown
Member Author

/backport to stable-3.30

@tobiasKaminsky

tobiasKaminsky commented Jan 3, 2025

Copy link
Copy Markdown
Member Author

We will then release a new version on monday.

@backportbot backportbot Bot mentioned this pull request Jan 3, 2025
Merged
This was referenced Jan 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 6, 2025
Closed
Closed
@ZetaTom ZetaTom mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes
@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

4 participants

@tobiasKaminsky @joshtrichards @CodeSteph @alperozturk96