Skip to content

MANAGE_EXTERNAL_STORAGE not possible for gplay flavor anylonger - #14099

Merged
tobiasKaminsky merged 5 commits into
masterfrom
removePermissionOnGPLAY
Dec 4, 2024
Merged

MANAGE_EXTERNAL_STORAGE not possible for gplay flavor anylonger#14099
tobiasKaminsky merged 5 commits into
masterfrom
removePermissionOnGPLAY

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • only for GPLAY
  • shows a warning only for users that use autoupload with move/delete
  • correctly show if files are read-only (folder read-only check seems not to be enough)
  • Tests written, or not not needed

alperozturk96
alperozturk96 reviewed Nov 29, 2024
View reviewed changes
Comment thread app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java
.show();
}

preferences.setAutoUploadGPlayWarningShown(true);

@alperozturk96 alperozturk96 Nov 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we set this true when showInfoDialog was also true? Maybe user will have synced folder later but this boolean already set it to true, thus user can't see dialog.

@tobiasKaminsky tobiasKaminsky Dec 2, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they set it up later, then they can only set it up with new behaviour, s to there is no need to inform them that something has changed.

@ZetaTom ZetaTom Dec 2, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently running the gplayDebug build variant and am still able to set the upload action to move or delete when setting up a custom auto upload folder. If I'm not mistaken, this option should be disabled.

@tobiasKaminsky tobiasKaminsky Dec 3, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On which API level? As older level will still work.
Hm. I did not thougth about it.
Then we should show this warning depending on API level?

@ZetaTom ZetaTom Dec 3, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On which API level?

I was using a Pixel 2 emulator running an AOSP image on API version 34 (Android 14). For testing, I did a fresh install each time, built using the gplayDebug variant.

@tobiasKaminsky tobiasKaminsky Dec 3, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try it with Android 15?

@tobiasKaminsky

tobiasKaminsky commented Dec 2, 2024

Copy link
Copy Markdown
Member Author

/backport to stable-3.30

@alperozturk96
alperozturk96 force-pushed the removePermissionOnGPLAY branch from 6bdad8b to e315793 Compare December 2, 2024 15:21
alperozturk96
alperozturk96 approved these changes Dec 2, 2024
View reviewed changes

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

ZetaTom
ZetaTom requested changes Dec 2, 2024
View reviewed changes
Comment thread app/src/main/res/values/strings.xml Outdated
Comment thread app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java
@tobiasKaminsky @ZetaTom
Update app/src/main/res/values/strings.xml
4811df6 
Co-authored-by: Tom <[email protected]>
Signed-off-by: Tobias Kaminsky <[email protected]>
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.30.6 milestone Dec 4, 2024
@tobiasKaminsky
show warning only on Android 11+
ef81f43 
Signed-off-by: tobiasKaminsky <[email protected]>
@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code298299
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total508509

SpotBugs increased!

@tobiasKaminsky
better gplay check
536a821 
Signed-off-by: tobiasKaminsky <[email protected]>
alperozturk96
alperozturk96 reviewed Dec 4, 2024
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/utils/BuildHelper.kt Outdated
@tobiasKaminsky
license
a30de8a 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
tobiasKaminsky merged commit f556167 into master Dec 4, 2024
@tobiasKaminsky
tobiasKaminsky deleted the removePermissionOnGPLAY branch December 4, 2024 14:36
@backportbot backportbot Bot mentioned this pull request Dec 4, 2024
Merged
@tobiasKaminsky
tobiasKaminsky restored the removePermissionOnGPLAY branch December 4, 2024 14:36
@tobiasKaminsky
tobiasKaminsky deleted the removePermissionOnGPLAY branch December 4, 2024 14:36
@MrRinkana MrRinkana mentioned this pull request Dec 16, 2024
Closed
@GuyFromMars365

GuyFromMars365 commented Dec 19, 2024

Copy link
Copy Markdown

If MANAGE_EXTERNAL_STORAGE is not possible in gplay, what reason did Google for provide for declining?According to this page, you would have to submit the Permissions Declaration Form to have this permission. I'm disappointed Google/Gplay/Android declined this request, as it almost renders the app partially useless.

@DragonQ

DragonQ commented Dec 22, 2024

Copy link
Copy Markdown

If MANAGE_EXTERNAL_STORAGE is not possible in gplay, what reason did Google for provide for declining?According to this page, you would have to submit the Permissions Declaration Form to have this permission. I'm disappointed Google/Gplay/Android declined this request, as it almost renders the app partially useless.

Is there any more info on what the Nextcloud team will do about this? As you say, it renders the app half useless.

Does the F-Droid version still work as it used to?

@aptalca

aptalca commented Dec 23, 2024

Copy link
Copy Markdown

The app stopped uploading geotags with the latest update for me. Is it perhaps related to this PR?

This was referenced Dec 24, 2024
Closed
Open
Closed
@Momi-V Momi-V mentioned this pull request Dec 24, 2024
Closed
4 tasks done
@Kveri Kveri mentioned this pull request Jan 7, 2025
Closed
4 tasks done
@Whisprin Whisprin mentioned this pull request Jan 8, 2025
Open
4 tasks done
@PeeK1e

PeeK1e commented Jan 12, 2025

Copy link
Copy Markdown

Is there any more info on what the Nextcloud team will do about this? As you say, it renders the app half useless.

Does the F-Droid version still work as it used to?

I installed the F-Droid Version, and I finally can upload my Signal backups again. So yes. It works.
Regarding the permissions, we have to hope for either the EU or the US to force Google to not be a monopolist. But you may wake me from my grave when that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes
@ZetaTom ZetaTom ZetaTom requested changes

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

Nextcloud App 3.30.6

Development

Successfully merging this pull request may close these issues.

7 participants

@tobiasKaminsky @GuyFromMars365 @DragonQ @aptalca @PeeK1e @alperozturk96 @ZetaTom