Repository navigation
Fix unresponsive preview player controls - #6805
Merged
tobiasKaminsky merged 1 commit intoAug 27, 2020
Merged
tobiasKaminsky merged 1 commit into
tobiasKaminsky merged 1 commit into
Conversation
Media controls view were covered by a ScrollView stealing all touch events. By changing it to FrameLayout, touch events can reach media controls. Content embedded inside ScrollView should not exceed screen boundaries. If so - content must be changed. This fixes immediate problem with unresponsive media controls reported in #6796 and #6782. Signed-off-by: Chris Narkiewicz <[email protected]>
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15561.apk |
Collaborator
Codacy408Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #6805 +/- ##
=========================================
Coverage 27.76% 27.77%
Complexity 5 5
=========================================
Files 427 427
Lines 34251 34251
Branches 4735 4735
=========================================
+ Hits 9511 9513 +2
+ Misses 23323 23322 -1
+ Partials 1417 1416 -1
|
tobiasKaminsky
approved these changes
Aug 27, 2020
delete-merged-branch
Bot
deleted the
ezaquarii/fix-unresponsive-audio-player-controls-with-linear-layout
branch
August 27, 2020 13:31
Member
|
/backport to stable-3.13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media controls view were covered by a ScrollView
stealing all touch events. By changing it to FrameLayout,
touch events can reach media controls.
Content embedded inside ScrollView should not
exceed screen boundaries. If so - content must
be changed.
This fixes immediate problem with unresponsive media controls
reported in #6796 and #6782.
Signed-off-by: Chris Narkiewicz [email protected]
Testing
Manual test: