Skip to content

Bruteforce - #65

Merged
mario merged 4 commits into
masterfrom
bruteforce
Jul 6, 2017
Merged

mario merged 4 commits into
masterfrom
bruteforce

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

lib changes for: nextcloud/android#1099

@AndyScherzinger

Copy link
Copy Markdown
Member

remove version dependency as NC can this in all supported version

would this drop some oC support? (as in oC server which aren't eol?)

@tobiasKaminsky

Copy link
Copy Markdown
Member Author

Prior oC 9.3. I am not completely sure what happens on older version, but hey we are NC ;-)

@AndyScherzinger

Copy link
Copy Markdown
Member

Prior oC 9.3. I am not completely sure what happens on older version, but hey we are NC ;-)

true, but we also have an unknown number of oC users using the Nc client...So according to https://github.com/owncloud/core/wiki/Maintenance-and-Release-Schedule I think it would be good if we support oC 9.0 not sure if that would then work out of the box.

@mario

mario commented Jun 30, 2017

Copy link
Copy Markdown
Contributor

@tobiasKaminsky I think you should kill the commit which removes the version check. Simple to do, but with potential benefits. Then we can merge.

@tobiasKaminsky

Copy link
Copy Markdown
Member Author

You mean so that it can work (maybe) for oc?

@mario

mario commented Jul 1, 2017

Copy link
Copy Markdown
Contributor

Indeed. There's nothing else that this commit does or brings, except potentially removes compatibility with oC.

@AndyScherzinger

AndyScherzinger commented Jul 5, 2017 •

Copy link
Copy Markdown
Member

👍

Approved with PullApprove

1 similar comment
@mario

mario commented Jul 6, 2017 •

Copy link
Copy Markdown
Contributor

👍

Approved with PullApprove

@mario
mario merged commit 64bf4b8 into master Jul 6, 2017
@mario
mario deleted the bruteforce branch July 6, 2017 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants