Vue share addressbook - #595

I would prefer all imports on the same file :)

copy also to the copyright header I will do this when in today as the first thing I do. Sorry forgot about the debouncer I need to think how I transfer these comments to a todo for myself, I loose them on github. I will work through the other points also. The only one is addnewaddressbook that is not my work and I think @suntala has probably updated this on her branch.

Arf, then forget about the new addressbook :) 🎉
Sorry 🙈

copyright header

copyright header

copyright header

Not necessary I guess? :)

Maybe too long?
I would go for something simpler I think.

you can also replace chosenUserOrGroup by { sharee, group }
Easier to understand and you don't need the let xxx =

I am not sure how this should work, the chosenUserOrGroup is an object that is the return from the custom options, it looks like this:

let newMatch = {
match: matches[i],
matchstart: matchResult[0],
matchpattern: matches[i].match(regex)[0],
matchend: matchResult[1],
matchtag: group ? '(group)' : '(user)',
matchgroup: group
}

How do I tell the multiselect to only pass on the match and matchgroup as suggested?

You can still pass the full object and destructure the only desired props :)

({ match, matchgroup } = {
    match: 0,
    matchstart: 1,
    matchpattern: 2,
    matchend: 3,
    matchtag: '(user)',
    matchgroup: 4
})

match
> 0
matchgroup
> 4

💯

There is a cleaner way to do that.
You can map the existing shares into an array of displaynames
let existingSharees = this.addressbook.shares.map(share => share.displayname)
Then you can filter out the shares
matches.filter(share => existingSharees.indexOf(share) === -1)
And then you can use map to create your newMatch object :)

Though this raises a few questions:

1. the group/user request returns displayNames, but we can have same displayName into a same instance
2. we should probably retrieve both data from the ocs api. and use ids and displayNames alongside

The api doc is not updated yet, but we can use /users/details and /groups/details to get the full data of a user.
https://github.com/nextcloud/server/blob/master/apps/provisioning_api/appinfo/routes.php#L37
Though we should then probably limit the number of results: https://github.com/nextcloud/server/blob/master/apps/provisioning_api/lib/Controller/UsersController.php#L156

I think we are approaching this a little different. I receive a array of names from both the ocs.data.users and ocs.data.groups and pass them to my formating function with a boolean to say if this was from a group or not (ie a user) Then I cross check this against my existing sharees using displayName + group as a primary key.

I love how concise the map function is, just trying to figure out how to do this here.

Yeah, my example is just to cross check against existing sharees :)

You cannot do that. You are not allowed to mutate data outside the store :)

You can do that directly in the object declaration

💯

I used 500 in the details, but this is a different behavior, so 250 is also fine :)

why the capital B ?

mistake!

Quick tip, you can just put group since it will be the same as group: group.
But don't bother, it's just a quick knowledge bump ;)

you could just do <span :class="sharee.group ? 'icon-group' : 'icon-user'" />

This is wrongly positioned, the debounce should be before the request, or we'll still get a big amount of requests which data won't be up to date. :)

See https://github.com/nextcloud/contacts/blob/vue/src/components/properties/PropertyMultipleText.vue#L123

I've taken 500 for the wait, correct?

match will return undefined if no match. so undefined[0] will throw an error :)

so I have done a check that match has a length and if not just returned out of it

You can also directly do that in a map :)

            this.usersOrGroups.concat(matches.map(match => {
                let matchResult = match.displayname.split(regex)
                return {
                    sharee: match.displayname,
                    id: match.id,
                    matchstart: matchResult[0],
                    matchpattern: match.displayname.match(regex)[0],
                    matchend: matchResult[1],
                    matchtag: group ? '(group)' : '(user)',
                    group
                }
            }))