Repository navigation
Vue avatar management - #647
Conversation
…er branch, still needs full styling
Vue avatar management preview
fixed toggleSize method
…avatar-management-style
Vue avatar management style
Vue avatar management style
sleepypioneer
added
3. to review
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
very nice work so far!!
This is working really nicely!!
| }, | ||
| methods: { | ||
| processFile(event) { | ||
| let file = event.target.files[0] |
There was a problem hiding this comment.
Cannot read property '0' of undefined after clicking the input.
So I'm guessing a simple click triggers a change, This is weird 🤔
| <template> | ||
| <div :class="{'maximised':maximizeAvatar }" class="contact-header-avatar"> | ||
| <div class="contact-header-avatar__background" @click="toggleSize" /> | ||
| <img v-if="contact.photo" :src="contact.photo" |
There was a problem hiding this comment.
Maybe use a background-image instead, otherwise the image is deformed if it's not square :)
| opacity: 1; | ||
| padding: 0; | ||
| // 300px padding on left to compensate for app-navigation having 1000 z-index | ||
| padding-left: 300px; |
There was a problem hiding this comment.
If you remove this and the padding: 20px 20px 20px 300px; it seems to work fine on my setup? :)
There was a problem hiding this comment.
can we then discuss what the final set up is? it does not work on mine and the app-navigation has the z-index 1000 Arati also had it up where it worked full screen so I'm not sure what is going on. Happy to remove it if it looks fine for you and your happy with that.
…contacts into vue-avatar-management
… into vue-avatar-management
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
added
4. to release
3 participants
Here is our work in progress on the Vue avatar Management, please look over it @skjnldsv and let us know if anything stands out as taking the wrong direction. We still need to do the delete photo and download photo functions.