Repository navigation
Board filter - #1507
Merged
Merged
Board filter#1507
Conversation
juliusknorr
reviewed
Jan 30, 2020
juliusknorr
force-pushed
the
enh/filter
branch
from
January 30, 2020 13:10
9ff8c2f to
1680550
Compare
Member
|
@jakobroehrl I've rebased the branch to current master, please make sure to reset your local branch to the origin one before continuing. |
juliusknorr
reviewed
Jan 30, 2020
juliusknorr
reviewed
Jan 30, 2020
juliusknorr
reviewed
Jan 30, 2020
juliusknorr
reviewed
Jan 30, 2020
Member
|
@jakobroehrl Pushed some fixes, feel free to take over again now 馃槈 |
jakobroehrl
force-pushed
the
enh/filter
branch
2 times, most recently
from
February 6, 2020 08:04
df63fe0 to
0d3299d
Compare
juliusknorr
reviewed
Feb 6, 2020
juliusknorr
reviewed
Feb 6, 2020
jakobroehrl
force-pushed
the
enh/filter
branch
2 times, most recently
from
February 6, 2020 10:19
1bdacda to
84046d8
Compare
Member
|
Lint is not happy, also as mentioned please rebase instead of creating merge commits, that allows us to maintain clean git log in the master branch. |
juliusknorr
reviewed
Feb 6, 2020
Member
There was a problem hiding this comment.
We should minify this one with https://github.com/nextcloud/server/blob/master/build/image-optimization.sh#L10
Contributor
Author
There was a problem hiding this comment.
ok, what is exactly to do?
juliusknorr
requested changes
Feb 6, 2020
jakobroehrl
force-pushed
the
enh/filter
branch
from
February 6, 2020 11:22
7306b59 to
5d67387
Compare
Signed-off-by: Jakob R枚hrl <[email protected]>
Signed-off-by: Jakob R枚hrl <[email protected]>
Signed-off-by: Julius H盲rtl <[email protected]>
Signed-off-by: Jakob R枚hrl <[email protected]>
Signed-off-by: Jakob R枚hrl <[email protected]>
Signed-off-by: Julius H盲rtl <[email protected]>
Signed-off-by: Julius H盲rtl <[email protected]>
jakobroehrl
force-pushed
the
enh/filter
branch
2 times, most recently
from
February 6, 2020 14:08
1249bc1 to
1cb7152
Compare
Signed-off-by: Jakob R枚hrl <[email protected]>
jakobroehrl
force-pushed
the
enh/filter
branch
from
February 6, 2020 14:14
1cb7152 to
85a6fc2
Compare
juliusknorr
approved these changes
Feb 6, 2020
Member
|
馃殌 |
|
Would it be possible to apply this filter across boards? I.e. at apps/deck/#!/ apply the filter and get the results? That would be very helpful. |
This was referenced Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo