Skip to content

fix(dev): fix attribute import and CSP example in controllers.rst - #15703

Open
whoalin1 wants to merge 1 commit into
nextcloud:masterfrom
whoalin1:fix-controllers-rst-attribute-csp-examples
Open

whoalin1 wants to merge 1 commit into
nextcloud:masterfrom
whoalin1:fix-controllers-rst-attribute-csp-examples

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 6, 2026 •

Copy link
Copy Markdown

Summary

Fixes three issues in developer_manual/basics/controllers.rst called out in #15679:

  • Attributes example imported PublicPage but used #[NoAdminRequired] — import the attribute that is actually used.
  • CSP example terminated the image-domain call with ;, breaking the media-domain chain, and never returned $response.
  • Document #[PasswordConfirmationRequired] in the controller attributes list.

Closes #15679

Test plan

  • Sphinx build of the developer manual succeeds for the controllers page
  • Attribute example imports match the attributes used on index()
  • CSP example is valid PHP (fluent chain + return $response;)
  • Attribute list includes #[PasswordConfirmationRequired] with a one-line explanation

AI disclosure

This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.

All commits carry an Assisted-by: Cursor:grok-4.7 trailer.

Assisted-by: Cursor:grok-4.7
Signed-off-by: whoalin1 <[email protected]>
@whoalin1
whoalin1 force-pushed the fix-controllers-rst-attribute-csp-examples branch from fcf544f to b98eb61 Compare October 9, 2026 14:13

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Developer manual: fix the attribute and CSP examples in controllers.rst

1 participant