Repository navigation
Conversation
Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <[email protected]>
whoalin1
force-pushed
the
fix-controllers-rst-attribute-csp-examples
branch
from
October 9, 2026 14:13
fcf544f to
b98eb61
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues in
developer_manual/basics/controllers.rstcalled out in #15679:PublicPagebut used#[NoAdminRequired]— import the attribute that is actually used.;, breaking the media-domain chain, and never returned$response.#[PasswordConfirmationRequired]in the controller attributes list.Closes #15679
Test plan
index()return $response;)#[PasswordConfirmationRequired]with a one-line explanationAI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.