Skip to content

Enh/vue image sidebar - #700

Merged
tacruc merged 12 commits into
enh/vue-rewritefrom
enh/vue-image-sidebar
Apr 14, 2022
Merged

Enh/vue image sidebar#700
tacruc merged 12 commits into
enh/vue-rewritefrom
enh/vue-image-sidebar

Conversation

@tacruc

@tacruc tacruc commented Mar 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR improves the interplay of the viewer with the nextcloud Sidebar.

Working and tested:

  • Open sidebar from Viewer
  • Viewer does not overlap with sidebar, but opens besides it
  • Viewer expands if sidebar is closed
  • sidebar goes into fullscreen mode, when viewer is open
  • Program a tab with information about files

To Solve

  • The viewer thinks, that the sidebar is opened on initial page load, even if it's not. Therefore opening the sidebar form the viewer menu only works, if the sidebar was closed before.

@tacruc
tacruc requested a review from julien-nc March 21, 2022 08:51
julien-nc
julien-nc reviewed Mar 22, 2022
View reviewed changes

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Could you make it so the sidebar closes when the image viewer is closed?

@julien-nc julien-nc mentioned this pull request Mar 22, 2022
Merged
@tacruc

tacruc commented Mar 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Awesome ! Could you make it so the sidebar closes when the image viewer is closed?

I could try, but then there is no way to open the sidebar for images, on the side of the map.
We could do a right click action open Sidebar for this.

And actually I think I would leave the sidebar and the viewer, two independent elements opening and closing independent, of each other. I think this is the way in the other apps, too.

@julien-nc

julien-nc commented Mar 22, 2022

Copy link
Copy Markdown
Member

Right, i think the same, then the only change to make is to not open the sidebar when an image is clicked and the viewer is opened.

@tacruc

This comment was marked as outdated.

Sign in to view
@tacruc
tacruc force-pushed the enh/vue-image-sidebar branch from 64275ae to f20797c Compare March 22, 2022 15:08
@tacruc

This comment was marked as outdated.

Sign in to view
@tacruc
tacruc force-pushed the enh/vue-image-sidebar branch 2 times, most recently from 004be79 to 0513695 Compare March 22, 2022 23:22
@tacruc

tacruc commented Mar 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Right, i think the same, then the only change to make is to not open the sidebar when an image is clicked and the viewer is opened.

It's done 馃槃

@tacruc tacruc mentioned this pull request Mar 23, 2022
Closed
@tacruc
tacruc requested a review from julien-nc March 23, 2022 13:51
@tacruc tacruc mentioned this pull request Apr 1, 2022
Merged
12 of 15 tasks
tacruc added 12 commits April 1, 2022 18:50
@tacruc
Included @nextcloud/event-bus": "^2.1.1
004c6ec 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Disabled Files Sidebar Tab, Notworking anyways
7d491c6 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Make the Viewer aware of maps sidebar
2e23a2b 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Make sidebar fullscreen, when viewer is opened
df9d7ba 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Dummy PhotoSidebarTab
f31d345 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Nicer photo sidebar
6c0d881 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Improve default Sidebar
33cc2a1 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Show favorits sidebar Icon in compact
3074586 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Add image menu element open sidebar
c55b6dd 
Don't open sidebar, when opening the viewer

Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Don't open sidebar if clicked on cluster
e8051d7 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Keep sidebar content if sidebar is toggled (onMainDetailClicked)
27b4e4c 
Clear sidebar if sidebar is closed (onSidebarClose; big X button top right of sidebar)

Signed-off-by: Arne Hamann <[email protected]>
@tacruc
Fix viewer assumes sidebar is opened on pageload
e25e6b3 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc
tacruc force-pushed the enh/vue-image-sidebar branch from 0513695 to e25e6b3 Compare April 1, 2022 16:51
@tacruc
tacruc merged commit 4b8aff2 into enh/vue-rewrite Apr 14, 2022
@tacruc
tacruc deleted the enh/vue-image-sidebar branch April 14, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tacruc @julien-nc