Skip to content

Migrated to App Bootstrap - #703

Merged
tacruc merged 5 commits into
masterfrom
Bootstrap
Jun 14, 2022
Merged

Migrated to App Bootstrap#703
tacruc merged 5 commits into
masterfrom
Bootstrap

Conversation

@tacruc

@tacruc tacruc commented Mar 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@tacruc tacruc mentioned this pull request Mar 23, 2022
Closed
@tacruc
Set APPID
0de1d15 
Signed-off-by: Arne Hamann <[email protected]>
@tacruc tacruc mentioned this pull request Mar 23, 2022
Merged
@tacruc tacruc changed the title Migrated to new App Bootstrap Migrated to App Bootstrap Mar 23, 2022
@tacruc

tacruc commented Apr 14, 2022

Copy link
Copy Markdown
Collaborator Author

Fixes #689

@codecov-commenter

codecov-commenter commented Jun 7, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #703 (f3d6256) into master (c51b083) will decrease coverage by 1.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #703      +/-   ##
============================================
- Coverage     58.31%   57.02%   -1.30%     
- Complexity     1138     1153      +15     
============================================
  Files            42       47       +5     
  Lines          3481     3539      +58     
============================================
- Hits           2030     2018      -12     
- Misses         1451     1521      +70
Flag Coverage Δ
unittests 57.02% <ø> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nextcloud/apps/maps/lib/Hooks/FileHooks.php 25.58% <0.00%> (-18.61%) ⬇️
nextcloud/apps/maps/lib/Service/TracksService.php 68.52% <0.00%> (-1.26%) ⬇️
...oud/apps/maps/lib/Listener/CardCreatedListener.php 0.00% <0.00%> (ø)
nextcloud/apps/maps/lib/AppInfo/Application.php 8.33% <0.00%> (ø)
...oud/apps/maps/lib/Listener/CardUpdatedListener.php 0.00% <0.00%> (ø)
...oud/apps/maps/lib/Listener/CardDeletedListener.php 0.00% <0.00%> (ø)
...aps/lib/Listener/LoadAdditionalScriptsListener.php 0.00% <0.00%> (ø)
nextcloud/apps/maps/lib/Helper/ExifGeoData.php 75.73% <0.00%> (+5.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f477d6d...f3d6256. Read the comment docs.

This was referenced Jun 14, 2022
Closed
Closed
Julien Veyssier
small adjustments
f3d6256 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc

julien-nc commented Jun 14, 2022

Copy link
Copy Markdown
Member

appinfo/application.php should be removed. Better to check if everything still works fine without it (file hooks and feature policy).

@tacruc
tacruc merged commit 5517748 into master Jun 14, 2022
@tacruc
tacruc deleted the Bootstrap branch June 14, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tacruc @codecov-commenter @julien-nc