Skip to content

Update master php testing versions - #755

Merged
nickvergessen merged 12 commits into
masterfrom
update-master-php-testing-versions
Apr 5, 2022
Merged

Update master php testing versions#755
nickvergessen merged 12 commits into
masterfrom
update-master-php-testing-versions

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Apr 4, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen mentioned this pull request Apr 4, 2022
Closed
44 of 45 tasks
szaimen
szaimen approved these changes Apr 4, 2022
View reviewed changes

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no phpunit here?

@come-nc

come-nc commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

There are unit test but no phpunit in CI, I will add it.

@come-nc come-nc self-assigned this Apr 4, 2022
come-nc added 4 commits April 4, 2022 10:37
@come-nc
Add phpunit to CI
eedb338 
Signed-off-by: C么me Chilliet <[email protected]>
@come-nc
Move phpunit files to tests folder
881754f 
Signed-off-by: C么me Chilliet <[email protected]>
@come-nc
Use setup-php@v2
3dcfa7b 
Signed-off-by: C么me Chilliet <[email protected]>
@come-nc
Fix folder paths in phpunit.xml
21c1b09 
Signed-off-by: C么me Chilliet <[email protected]>
nickvergessen
nickvergessen commented Apr 4, 2022
View reviewed changes
Comment thread .github/workflows/phpunit.yml Outdated
@nickvergessen

nickvergessen commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

Run ./vendor/phpunit/phpunit/phpunit -c ./tests/phpunit.xml
PHP Warning: require_once(PHPUnit/Autoload.php): failed to open stream: No such file or directory in /home/runner/work/privacy/privacy/apps/privacy/tests/bootstrap.php on line 16
PHP Fatal error: require_once(): Failed opening required 'PHPUnit/Autoload.php' (include_path='/home/runner/work/privacy/privacy/3rdparty/pear/archive_tar:/home/runner/work/privacy/privacy/3rdparty/pear/console_getopt:/home/runner/work/privacy/privacy/3rdparty/pear/pear-core-minimal/src:/home/runner/work/privacy/privacy/3rdparty/pear/pear_exception:/home/runner/work/privacy/privacy/apps') in /home/runner/work/privacy/privacy/apps/privacy/tests/bootstrap.php on line 16
Error: Process completed with exit code 255.

@nickvergessen

nickvergessen commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

Added the summaries as required

@come-nc
Update tests
944cc5f 
Signed-off-by: C么me Chilliet <[email protected]>
@come-nc
come-nc force-pushed the update-master-php-testing-versions branch from 0cb5d33 to 944cc5f Compare April 4, 2022 11:42
@nickvergessen

nickvergessen commented Apr 4, 2022

Copy link
Copy Markdown
Member Author
  1. OCA\Privacy\Tests\Unit\Controller\PageControllerTest::testIndex
    Error: Class 'OCA\Privacy\Controller\PageController' not found

The test files look pretty broken, maybe that is why it wasn't run at all :D

@come-nc

come-nc commented Apr 4, 2022

Copy link
Copy Markdown
Contributor
  1. OCA\Privacy\Tests\Unit\Controller\PageControllerTest::testIndex
    Error: Class 'OCA\Privacy\Controller\PageController' not found

The test files look pretty broken, maybe that is why it wasn't run at all :D

PageControllerTest is the only non-empty test and there is no PageController class in the app 馃

@nickvergessen

nickvergessen commented Apr 4, 2022

Copy link
Copy Markdown
Member Author

rm -rf tests/* ?

@come-nc

come-nc commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

rm -rf tests/* ?

If you commit it I approve it :-P

@nickvergessen
Do integration tests work?
596a513 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Comment out option
e7d26b2 
Signed-off-by: Joas Schilling <[email protected]>
@come-nc
come-nc force-pushed the update-master-php-testing-versions branch from fc3a8a1 to 02d030d Compare April 4, 2022 14:57
nickvergessen
nickvergessen commented Apr 4, 2022
View reviewed changes
Comment thread .github/workflows/phpunit-mysql.yml Outdated
@come-nc
Run only if file exists
f821c48 
Signed-off-by: C么me Chilliet <[email protected]>
@come-nc
come-nc force-pushed the update-master-php-testing-versions branch from 02d030d to f821c48 Compare April 4, 2022 15:20
nickvergessen
nickvergessen commented Apr 4, 2022
View reviewed changes
Comment thread .github/workflows/phpunit-mysql.yml Outdated
@nickvergessen
Make sure ID is unique
f0daec0 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen mentioned this pull request Apr 5, 2022
Merged
@nickvergessen

nickvergessen commented Apr 5, 2022

Copy link
Copy Markdown
Member Author

Works now, last sign of approval? @come-nc

@come-nc

come-nc commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

No integration tests are not run.

@come-nc

come-nc commented Apr 5, 2022

Copy link
Copy Markdown
Contributor 
The workflow is not valid. .github/workflows/phpunit-mysql.yml (Line: 82, Col: 9): Unexpected value 'working-directory' .github/workflows/phpunit-mysql.yml (Line: 95, Col: 9): Unexpected value 'working-directory'
锟糞how more

馃槥

@come-nc
Improve naming and fix working dir
e555ac0 
Signed-off-by: C么me Chilliet <[email protected]>
@come-nc
come-nc force-pushed the update-master-php-testing-versions branch from 90e72ff to e555ac0 Compare April 5, 2022 07:01
@come-nc

come-nc commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Finally 馃コ 馃巻

@nickvergessen
nickvergessen merged commit c08f04c into master Apr 5, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the update-master-php-testing-versions branch April 5, 2022 07:21
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc left review comments
@mejo- mejo- mejo- approved these changes
@szaimen szaimen szaimen approved these changes

Assignees

@come-nc come-nc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @come-nc @mejo- @szaimen