Repository navigation
Implement user mentions API - #2576
Merged
Merged
Conversation
Raudius
added
enhancement
Signed-off-by: Raul <[email protected]>
Raudius
force-pushed
the
enh/user_mentions
branch
from
October 24, 2022 11:34
aa6d6de to
49de569
Compare
6 tasks done
juliusknorr
reviewed
Nov 16, 2022
| }).catch(() => { | ||
| return documentsMain.users | ||
| }).then((users) => { | ||
| const list = users.map((user) => { |
Member
There was a problem hiding this comment.
Could we do this right away if there is no user session available so that we skip the failing request?
Contributor
Author
There was a problem hiding this comment.
Yep nice suggestion, I changed the logic around
juliusknorr
reviewed
Nov 16, 2022
juliusknorr
left a comment
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Just one minor comment and eslint needs some love. Otherwise good from my side 馃憤
Signed-off-by: Raul <[email protected]>
Raudius
force-pushed
the
enh/user_mentions
branch
from
November 17, 2022 11:24
98417ba to
851a5f1
Compare
Contributor
Author
|
/backport to stable25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the post message API to allow user mentions in Collabora