Skip to content

fix: Emit notification on mentions - #3960

Merged
elzody merged 1 commit into
mainfrom
fix/mention-notification
Sep 27, 2024
Merged

elzody merged 1 commit into
mainfrom
fix/mention-notification

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Aug 29, 2024 •

Copy link
Copy Markdown
Member

It seems we totally missed this part when implementing the initial mention support back in the days.

This will emit a notification to mentioned users that can be clicked, just like it works in text.

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable30

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable29

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable28

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable27

Comment thread lib/Controller/MentionController.php Outdated
@juliusknorr
juliusknorr force-pushed the fix/mention-notification branch 2 times, most recently from d1cbd64 to 08e5649 Compare September 18, 2024 10:10
@juliusknorr
juliusknorr force-pushed the fix/mention-notification branch from 08e5649 to b7a435d Compare September 19, 2024 18:28
@Rash419

Rash419 commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

@juliushaertl hey
I tried it on master branch for nextcloud server, richdocuments, notification app and Collabora Online master . From online I see Meniton_UI selected message going to richdocument. But I don't see any new notification in the nextcloud UI. Am I missing something ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Ready to be reviewed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants