Skip to content

Comment icon is not shown on shared folder #10877

Description

@tobiasKaminsky
  • share a folder A from user 1 to user 2
  • add a comment on this folder A
  • log in as user 2 and see no comment icon on this folder

It works if user 1 is commenting something on a file b.txt within A (A/b.txt)

@blizzz (as suggested by Joas)

Activity

  1. nextcloud-bot commented on Aug 27, 2018

    @nextcloud-bot
    Member

    GitMate.io thinks possibly related issues are #4246 (Shared folder to a group not shown in shared by me), #7125 (Plugins not working on Shared Folders), #5408 (Files: not all shares are shown if folder is marked as favorite), #10308 (Shared folder icons and text is showed inconsistently), and #1072 (Not possible to share current folder (need to display share icon in the breadcrumbs)).

  2. blizzz commented on Sep 3, 2018

    @blizzz
    Member

    The WebDAV property returns an unread count of 0. Debugging why tomorrow. So far I failed to see that DAV Comments plugins where pulled in at all (but the property is coming somehwere from).

  3. blizzz commented on Sep 5, 2018

    @blizzz
    Member

    Introduced with 429f8ae

  4. added this to the Nextcloud 15 milestone on Sep 5, 2018
  5. blizzz commented on Sep 5, 2018

    @blizzz
    Member

    I guess the crucial point is that the implementation of getNumberOfUnreadCommentsForFolder works against the filecache table and does not take mounts/shares into account. Thus, even if you get a number it is not necessarily precise.

    @icewind1991 you've got an idea how to resolve this without losing too much of the performance benefits?

  6. danxuliu commented on Dec 17, 2018

    @danxuliu
    Member

    Fixed by #12897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions