Repository navigation
jQuery UI tabs should match the Nextcloud tab style #1090
Description
follow up of #830
At the moment jQuery UI styles don't match the clean Nextcloud look:
actually the color should be removed from jQuery UI. The tabs should be styled like the tabs in the right Files details sidebar instead.
cc @nextcloud/designers @jancborchardt
Activity
MariusBluem commentedon Aug 26, 2016
Good :) However: I think the best would be to drop this tabs as we have already done in
user_saml. Same foruser_ldapwould be great but is something for another issue 😉jancborchardt commentedon Aug 26, 2016
@blizzz do you think it’s a good idea to drop the tabs altogether? With the now split admin settings it might be good to use the tabs as h2 elements instead to structure the page.
raghunayyar commentedon Aug 28, 2016
@jancborchardt @blizzz we can use the tabs we once had in the files sidebar here? They happen to be a quick fix and afaik dont rely on jQuery UI.
blizzz commentedon Aug 28, 2016
@jancborchardt it would still need a guided concept. The main idea was to make it easy to configure and do not overwhelm the admin with stuff. So, just placing everything below each other would not suffice, it would still require some logic. Also, Advanced and Expert tabs have a lot of cargo, i.e. also needs extra treatment.
An idea that just comes to my head is to place the wizardy tabs (Server, User, Login, Groups) below each other. On new configurations (and those without valid host and credentials) only the Server part is visible or active. Once this is configured and/or valid other parts are shown. Advanced and Expert settings would stay as tabs, only the appearance change. Tedious work altogether, though, and there are better places to spend efforts.
I'd appreciate just changing the style to follow tabs as in the files sidebar.
MorrisJobke commentedon Aug 18, 2017
Fixed in #771
MorrisJobke commentedon Aug 18, 2017
Regression in #6178
MorrisJobke commentedon Sep 3, 2017
Fixed in #6341