Skip to content

Lower button cut off in the destination folder dialog #11315

Description

@j-ed

Expected behavior

If files are copied or moved to a new folder, all displayed buttons in the destination folder dialog should be correctly displayed without the requirement to scroll down the dialog window.

Current behavior

The lower button is cut off in the initially displayed destination folder dialog. You need to scroll down to get it displayed correctly.

2018092_nc_copy_move_dialog

Steps to reproduce

  1. Select two files to be copied
  2. Navigate to the destination folder.
  3. Check out how the buttons are displayed.

Environment

Server Configuration

OS: Linux 3.16.57
Web server: Apache2 2.4.33
Database: MariaDB 10.0.32
PHP version: 5.6.34
Nextcloud version: 13.0.6

Client Configuration

Browser: Mozilla Firefox 62.0
Operating system: Windows 10

Activity

  1. nextcloud-bot commented on Sep 21, 2018

    @nextcloud-bot
    Member

    GitMate.io thinks possibly related issues are #10897 (Buttons overlaps scrollbar in "Target folder" dialog), #2245 (Folder name input cut off), #10679 (switches the oc dialog button row to flex), #6375 (Favicon cut off on the right), and #7588 (Folder permissions).

  2. self-assigned this
    on Sep 22, 2018
  3. weeman1337 commented on Sep 22, 2018

    @weeman1337
    Member

    @j-ed thanks for the report.

    I can confirm the problem with Nextcloud 13.

    It's not perfect in dev and 14, but it works:
    image

    I'll have a look.

  4. weeman1337 commented on Sep 22, 2018

    @weeman1337
    Member

    The buttons could even have more than two lines if the name is long enough. I would suggest going for the text overflow ellipsis here:

    image

    @nextcloud/designers any opinions here?

  5. skjnldsv commented on Sep 24, 2018

    @skjnldsv
    Member

    @weeman1337 the last one is great I think :)

  6. pixelipo commented on Sep 24, 2018

    @pixelipo
    Contributor

    Why doesn't the button just simply say one of the following?

    • "Move/Copy here"
    • "Move/Copy to this folder"
    • "Move/Copy to current folder"
  7. weeman1337 commented on Sep 26, 2018

    @weeman1337
    Member

    I could imagine the folder name in the buttons is to make it clear where the file goes to.

  8. MorrisJobke commented on Oct 1, 2018

    @MorrisJobke
    Member

    Fixed by #11522

  9. added this to the Nextcloud 15 milestone on Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions