Skip to content

JS Unit tests for file drop fail #124

Description

@MorrisJobke

Those 6 unit tests fail:

PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload dropping external files drop on a tr or crumb outside file list does not trigger upload FAILED
    Expected undefined to equal false.
    /drone/src/apps/files/tests/js/filelistSpec.js:2394:30
    Expected undefined to equal false.
    /drone/src/apps/files/tests/js/filelistSpec.js:2397:30
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload dropping external files drop on an element outside file list container does not trigger upload FAILED
    Expected undefined to equal false.
    /drone/src/apps/files/tests/js/filelistSpec.js:2405:30
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload dropping external files drop on an element inside the table does not trigger upload if no upload permission FAILED
    Expected undefined to equal false.
    /drone/src/apps/files/tests/js/filelistSpec.js:2424:30
    Expected false to equal true.
    /drone/src/apps/files/tests/js/filelistSpec.js:2425:48
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload dropping external files drop on an folder does not trigger upload if no upload permission on that folder FAILED
    Expected undefined to equal false.
    /drone/src/apps/files/tests/js/filelistSpec.js:2433:30
    Expected false to equal true.
    /drone/src/apps/files/tests/js/filelistSpec.js:2434:48
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload dropping external files drop on a folder row inside the table triggers upload to target folder FAILED
    Expected undefined to equal '/subdir/somedir'.
    /drone/src/apps/files/tests/js/filelistSpec.js:2447:41
PhantomJS 2.1.1 (Linux 0.0.0) OCA.Files.FileList tests file upload dropping external files drop on a breadcrumb inside the table triggers upload to target folder FAILED
    Expected undefined to equal '/a/b'.
    /drone/src/apps/files/tests/js/filelistSpec.js:2455:41

Bisecting shows, that this is since 937d21e

Maybe @vincchan has an idea how to fix this. I will also try to dig into this.

Activity

  1. added this to the milestone on Jun 16, 2016
  2. self-assigned this
    on Jun 16, 2016
  3. added a commit that references this issue on Jun 16, 2016
    51b067d
  4. MorrisJobke commented on Jun 16, 2016

    @MorrisJobke
    MemberAuthor

    Fix is in #125

  5. removed their assignment
    on Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions