Repository navigation
Comments: Replace CommentEntityEvent with a registration-bases solution within CommentsManager. #1539
Description
Currently, adding DAV support to other than 'files' type of comments, a dispatcher is being used to register a closure, which is handled by the comments RootCollection.
The CommentsManager should take this over and offer a possibility to register SubCollections as such. The RootCollection would query it let the corresponding instance continue.
The new API and switch from the Dispatcher shall be communicated with the release notes and possibly on Discourse.
As discussed with @nickvergessen while working at #1449
Activity
szaimen commentedon May 21, 2021
I suppose this issue is still valid? If not, please close this issue!
nickvergessen commentedon May 21, 2021
It not has those dedicated event. Sounds good enough for me atm. What do you think @blizzz
blizzz commentedon Jul 12, 2023
if there is no need, we can just close it, instead of keeping it open eternally. can always reopen.
nickvergessen commentedon Jul 13, 2023
PR at #39304 cough