Skip to content

Sort favorite files first in the list #1802

Description

@jancborchardt

Favoriting is not very integrated at the moment. Only an indicator, we can do better here.

Better integration without needing to switch to a separate view would be to always sort the favorited items of a the current folder up top.

Already done in Android, ref nextcloud/android#107 @nextcloud/javascript

Activity

  1. added this to the Nextcloud 11.0 milestone on Oct 19, 2016
  2. nickvergessen commented on Oct 20, 2016

    @nickvergessen
    Member

    Just noting: the web UI get files in batches, so when you scroll down it preloads more files. But this means that the initial list of files may not contain all your favorites. SO only "some" will appear at teh top, unless this is added fully to the api, in which case n/javascript is the wrong mention. 😦

  3. jancborchardt commented on Oct 20, 2016

    @jancborchardt
    MemberAuthor

    Ah ok – how do we get the favorites in the files filter then? We should do it like there. cc @icewind1991

  4. nickvergessen commented on Oct 20, 2016

    @nickvergessen
    Member

    The filter uses a completly different endpoint

  5. ryanwr commented on Oct 21, 2016

    @ryanwr
    Contributor

    I think the sorting should be done server side, I think I've got an idea of how to do it, I'll have a go

  6. ryanwr commented on Oct 22, 2016

    @ryanwr
    Contributor

    @nickvergessen I'm not sure if I'm missing something but does the client receive batches of files from the webdav server? How does the webdav server paginate requests?

  7. ChristophWurst commented on Oct 22, 2016

    @ChristophWurst
    Member

    @ryanwr the pagination is done on the client, which means the folder content it fetched with a single webdav request AFAIK.

  8. ryanwr commented on Oct 22, 2016

    @ryanwr
    Contributor

    @ChristophWurst Thanks! That's helpful

  9. ryanwr commented on Oct 22, 2016

    @ryanwr
    Contributor

    Opened a PR, I'd appreciate feedback on it!

  10. rullzer commented on Oct 25, 2016

    @rullzer
    Member

    Merged in #1860 thanks @ryanwr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions