Skip to content

No way to accept shares if notifications app is not enabled #18255

Description

@icewind1991

Since #16828, when a file is shared but the notifications app is not installed, there is no way to accept the share nor is any feedback given, everything looks fine for the person creating the share, but the recipient doesn't see anything.

Not having the notifications app is probably not common (outside git dev installs) but it's not a force enabled app

@nickvergessen @rullzer

Activity

  1. nickvergessen commented on Dec 5, 2019

    @nickvergessen
    Member

    Right, does federation still have a workaround for this, or are they also broken?

  2. rullzer commented on Dec 5, 2019

    @rullzer
    Member

    Probably still has a workaround I bet. I can check later.

  3. nickvergessen commented on Dec 6, 2019

    @nickvergessen
    Member

    This topic came up in the office today and @karlitschek said we dont need to workaround if people disable a default enabled shipped app.

    But we should add a config to automatically accept shares in some bigger enviroments.

  4. self-assigned this
    on Dec 6, 2019
  5. added this to the Nextcloud 18 milestone on Dec 6, 2019
  6. karlitschek commented on Dec 6, 2019

    @karlitschek
    Member
  7. jospoortvliet commented on Dec 6, 2019

    @jospoortvliet
    Member

    Imho the user sharing settings should have a

    • automatically accept incoming shares

    This should be disabled by default. This makes this feature opt-in which is probably the right thing to do as it is quite a change of behavior if we make this default.

    An OCC command or config.php option for this is probably also needed to change the default.

  8. wiswedel commented on Dec 12, 2019

    @wiswedel
    Contributor

    Let's follow up on Jos' suggestion (that I fully agree on) in a separate issue: #18373

  9. rullzer commented on Dec 12, 2019

    @rullzer
    Member

    See #18384 for the config.php setting
    And #18385 for the user setting

    The user setting will only be available if the config.php override is not set.

  10. wiswedel commented on Dec 13, 2019

    @wiswedel
    Contributor

    The user setting will only be available if the config.php override is not set.

    nice approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions