Skip to content

App-navigation without settings should not have padding-bottom #2189

Closed
#2283
Closed
App-navigation without settings should not have padding-bottom#2189
#2283
Labels
bugdesignDesign, UI, UX, etc.good first issueSmall tasks with clear documentation about how and in which place you need to fix things in.
Milestone
Nextcloud 11.0

Description

@jancborchardt
jancborchardt
opened on Nov 17, 2016

Since #app-settings is inside #app-navigation, we can not do this via CSS. We probably need to add a class ».without-app-settings« to the #app-navigation via JS when there’s no settings, and then via CSS:

#app-navigation.without-app-settings {
   padding-bottom: 0;
}

capture du 2016-11-17 18-40-15

cc @BernhardPosselt @nextcloud/designers @nextcloud/javascript

Activity

  1. jancborchardt
    added
    1. to developAccepted and waiting to be taken care of
    bug
    designDesign, UI, UX, etc.
    good first issueSmall tasks with clear documentation about how and in which place you need to fix things in.
    on Nov 17, 2016
  2. jancborchardt
    added this to the Nextcloud 11.0 milestone on Nov 17, 2016
  3. MorrisJobke
    added a commit that references this issue on Nov 23, 2016

    Remove padding from apps navigation if there is no settings area

    51b7d04

  4. MorrisJobke commented on Nov 23, 2016

    @MorrisJobke
    MorrisJobke
    on Nov 23, 2016
    Member

    Fix is in #2283

  5. MorrisJobke
    removed
    1. to developAccepted and waiting to be taken care of
    on Nov 23, 2016
  6. juliusknorr
    closed this as completedin #2283on Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugdesignDesign, UI, UX, etc.good first issueSmall tasks with clear documentation about how and in which place you need to fix things in.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions