Repository navigation
Missing pieces: user mentions in Comments #2443
Description
Activity
😅
Reacted by Jos Poortvliet and Marcel PartapHahaha @foobar :D welcome
@blizzz two things:
- we would do autocomplete suggestions across usernames and realnames, right?
- do we insert a space automatically after the @-mentioned name, like Github? The lack of that in Discourse for example I find really strange
Let's push this because without autocompletion the feature is basically not really discoverable.
we would do autocomplete suggestions across usernames and realnames, right?
Basically I'd follow what sharing is doing. The typed string is passed to the user backends, and what they are looking at is their business. Local ones do username and display name i believe.
do we insert a space automatically after the @-mentioned name, like Github? The lack of that in Discourse for example I find really strange
Reasonable to do so, I agree.
Let's push this because without autocompletion the feature is basically not really discoverable.
And shouldn't be, I guess, it's more groundwork right now. Though it works if you know how to mention whom ;)
Reacted by Jan C. Borchardt and Frithjof@blizzz any progress here or something to review?
nope, i've other prios so far unfortunately
One other thing:
When writing or editing a comment and typing an @ in the beginning of a word followed by another character an auto-complete is offered.
We should already offer the autocomplete as soon as the @ is typed. It should prioritize showing them in this order:
- People who commented on this file previously.
- People who can see this file / have it shared with them.
- Contacts you most mentioned or interacted with.
People who can see this file / have it shared with them.
Those who cannot access it, should not be shown at all. Or, otherwise, showing them (then of course only those that potentially can get access) and eventually mentioning them would also include creating a share.
Contacts you most mentioned or interacted with.
Basically like above, but it would end up as federated or mail share. Thus, also only offering those we potentially can get access.
I added the Implementation specs part into the description and would follow this scheme. This should allow auto completion not only for File Comments, but in any other place too (e.g. calendar descriptions), while still not being bloated. Most requirements come from File Comments itself.
Perhaps you want to have a look and leave input? @schiessle @nickvergessen @LukasReschke @MorrisJobke (and anyone else is invited, too, of course). Beware, since I won't have much time left until i am off for a longer while until the conf, I am going to take on the implementation swiftly (with the risk of changes in case I oversaw a thing).
13 remaining items
@blizzz do you think the @-mention-suggestions will make it into 13? Anything up for review? :)
@blizzz Seems to be delayed again, right? Move to 15?
Nothing for 14 it seems -> moved to 15
I have a local fix for mentions with spaces.
Reacted by Arthur Schiwon
With 11 we put the cornerstones for user mentioning in comments (cf. #753). It's not end user friendly yet, though. For Nc 12 we have left to accomplish:
When writing or editing a comment and typing an @ in the beginning of a word followed by another character an auto-complete is offered. It only includes users that have access to the file. Results are supposed to show up with a slight delay. For scaling reasons, it needs to be figured out whether all possible users are fetched in the background in advance, or on demand (like search dialog). done in 13
Usernames are somehow allowed to contain whitespaces. They are currently not supported by our regex syntax. To be truly compatible we need to change the underlying markup and, for instance, wrap the mention into
[ ]brackets (see below). Changes needs to be reflected into clients so they render properly (comments UI in sidebar, notifications, activites, …)upon click on a comment notification, currently only the corresponding page within Files is being opened. Additionally, the sidebar should be opened with the Comments section active. The new comment should be highlighted, also.
Not fully supported username examples
"Let's talk about it today, @foobar."
Since we allow dots,
@foobarand@foobar.are possible scenarios here. If you have both? Would be silly to insert a space between the username and the fullstop.But even better it is that we allow white spaces in usernames now:
"@alice Bernadette wants to talk"
Username can be
'@Alice Bernadette'or'@Alice'(or both).For now, I improve the Regexp to have the 98% solution, butt when going with autocomplete I am afraid we need to wrap the mention into brackets to be able to support all these funny usernames.
Nice to have
Update Jul 12th and again on Jul 14th
Implementation specs
Overview
[@$id]for commentsid,labelandsourceas keys