Repository navigation
Remove php 7.3 from testing of apps #30896
Description
- Update master php testing versions activity#714
- Update master php testing versions files_pdfviewer#556
- Update master php testing versions firstrunwizard#669
- Update master php testing versions logreader#644
- Update master php testing versions nextcloud_announcements#96
- Update master php testing versions notifications#1143
- Update master php testing versions password_policy#319
- Update master php testing versions photos#1020
- Update master php testing versions privacy#689
- Update master php testing versions recommendations#476
- Update master php testing versions serverinfo#357
- Update master php testing versions viewer#1150
- Update master php testing versions announcementcenter#431
- Update master php testing versions backup#178
- Update master php testing versions circles#923
- Update master php testing versions data_request#63
- Update master php testing versions deck#3561
- Update master php testing versions end_to_end_encryption#276
- Update master php testing versions files_accesscontrol#230
- Update master php testing versions files_automatedtagging#534
- Update master php testing versions files_retention#151
- Update master php testing versions flow_notifications#43
- Update master php testing versions groupfolders#1886
- Update master php testing versions impersonate#147
- Update master php testing versions quota_warning#90
- Update master php testing versions sharepoint#117
- Update master php testing versions spreed#6844
- Update master php testing versions terms_of_service#679
- Update master php testing versions text#2137
- Update master php testing versions user_retention#418
- Update master php testing versions workflow_pdf_converter#373
- Update master php testing versions workflow_script#110
- Drop php 7.3 .github#44
Activity
@nickvergessen Shouldn’t we add 8.1 as well?
Reacted by John MolakvoæYes, with org environment, but this is a hard restriction, people might not like it.
Requires a good discussion priorShouldn’t we add 8.1 as well?
One after the other. Especially since dropping would make apps fail after the merge of #29286 but adding 8.1 to server doesn't break anything.
On that note, 8.1 might require a new phpunit version and might therefor require more back and forthReacted by John MolakvoæWondering if this could be defined globally
We can't really as there are many apps which support multiple branches. And e.g. if your app supports 20-23 you need to lint and test on 7.2 + 7.3 as well. This is also the reason why I only send my update to apps with stable branches
- Update master php enviroment files_pdfviewer#561
- Update master php enviroment nextcloud_announcements#97
- Update master php enviroment photos#1028
- Update master php enviroment privacy#696
- https://github.com/nextcloud-gmbh/support/pull/132
- Update master php enviroment viewer#1157
- Update master php enviroment announcementcenter#436
- Update master php enviroment backup#185
- Update master php enviroment circles#925
- Update master php enviroment deck#3582
- Update master php enviroment end_to_end_encryption#283
- Update master php enviroment groupfolders#1892
- Update master php enviroment quota_warning#91
Shouldn’t we add 8.1 as well?
One after the other. Especially since dropping would make apps fail after the merge of #29286 but adding 8.1 to server doesn't break anything. On that note, 8.1 might require a new phpunit version and might therefor require more back and forth
We are approaching 24 release which needs to support 8.1.
Can you open the same kind of PRs to add 8.1 testing and linting?Added as todo for next week
Adding 8.1 is in #31817
