You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Removed background image from theming should apply on new UI #33797
Both dashboard and the theming app have the option to remove the background image and use the plain theming color. This is currently not being handled by the new page background in DefaultTheme.php
Example where this does lead to unexpected results: System is set to dark mode, as is Firefox. NC is set to follow system. In settings/admin/theming (global) BG color is set to #888888 and a BG image is set to a (slightly darker) image. In /settings/user/theming, BG is set to "Plain Background". Thus, the BG image should only be used on the login page (and public pages?).
[Sidenote: There's also a localization glitch here.]
With this setting, I expect all pages (while logged in) to NOT show the BG image. In fact, /settings/user/theming honors that, but all other pages don't:
Additionally, the man navigation icons' color should not change.
[Sidenote: It doesn't work either if NO BG image is set at all. In that case, the default cloud image is shown as background although the preview in settings/admin/theming shows the plain set bg-color background.]
As far as I undrstood, there is a check now for the admin to properly disable user-defined background (and primary after #34272)
When the admin disabled that option, THEN the background removal would apply and be enforced everywhere, using the primary only
@skjnldsv admin settings have (almost) nothing to do with this, it's about the user setting of plain background.
@nursoda's screenshot shows the admin section, which also include a "disable background image", which is very weird to have considering all those values now.
Like the primary colour (chosen by admin), it almost have no visible effect on the user since there are custom themes enabled by default.
Activity
nursoda commentedon Sep 19, 2022
Example where this does lead to unexpected results: System is set to dark mode, as is Firefox. NC is set to follow system. In settings/admin/theming (global) BG color is set to #888888 and a BG image is set to a (slightly darker) image. In /settings/user/theming, BG is set to "Plain Background". Thus, the BG image should only be used on the login page (and public pages?).
[Sidenote: There's also a localization glitch here.]
With this setting, I expect all pages (while logged in) to NOT show the BG image. In fact, /settings/user/theming honors that, but all other pages don't:
Additionally, the man navigation icons' color should not change.
[Sidenote: It doesn't work either if NO BG image is set at all. In that case, the default cloud image is shown as background although the preview in settings/admin/theming shows the plain set bg-color background.]
skjnldsv commentedon Sep 28, 2022
As far as I undrstood, there is a check now for the admin to properly disable user-defined background (and primary after #34272)
When the admin disabled that option, THEN the background removal would apply and be enforced everywhere, using the primary only
Please confirm @jancborchardt
jancborchardt commentedon Sep 28, 2022
@nursoda yes, that expectation is correct.
@skjnldsv admin settings have (almost) nothing to do with this, it's about the user setting of plain background.
@Pytal can you confirm that what @juliushaertl and @nursoda describe is fixed, or is there something in progress / to do?
skjnldsv commentedon Sep 28, 2022
@nursoda's screenshot shows the admin section, which also include a "disable background image", which is very weird to have considering all those values now.
Like the primary colour (chosen by admin), it almost have no visible effect on the user since there are custom themes enabled by default.
Pytal commentedon Sep 28, 2022
Yes, fixed in #34204