Repository navigation
[Bug]: cachebuster value rising infinitely #34457
Description
⚠️ This issue respects the following points: ⚠️
- This is a bug, not a question or a configuration/webserver/proxy issue.
- This issue is not already reported on Github (I've searched it).
- Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
- Nextcloud Server is running on 64bit capable CPU, PHP and OS.
- I agree to follow Nextcloud's Code of Conduct.
Bug description
The app config value for cachbuster of theming is constantly rising. This prevents caching on frontend resources, and has side effects on Talk. Because this is used in calculating a hash, it appears that resources were changed and requires a reload. This happens infinitely.
This was introduced in #34432 specifically the added lines 227 and 230 in apps/theming/lib/ThemingDefaults.php. The behaviour becomes normal when the lines are commented out, alas this may have other side effects I am not aware of.
Steps to reproduce
- Run Nextcloud 25 RC3 (earlier versions not affected)
- Have Nextcloud Talk open
Expected behavior
Talk does not think the instances was updated every 30s.
Installation method
No response
Operating system
No response
PHP engine version
No response
Web server
No response
Database engine version
No response
Is this bug present after an update or on a fresh install?
No response
Are you using the Nextcloud Server Encryption module?
No response
What user-backends are you using?
- Default user-backend (database)
- LDAP/ Active Directory
- SSO - SAML
- Other
Configuration report
No response
List of activated Apps
not relevantNextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
Activity
blizzz commentedon Oct 6, 2022
@Pytal would you mind investigating that?
Pytal commentedon Oct 7, 2022
The cachebuster value was increased here
server/apps/theming/lib/ThemingDefaults.php
Lines 227 to 230 in 0112a29
in #34298 to ensure that assets like the favicon would display correctly for the user based on the auto-selected color preset from the shipped background
Will see if I can come up with a solution that will work alongside the latest theming updates
PVince81 commentedon Oct 11, 2022
I heard that it's critical because it increases the load on the server and Talk users get a message that they need to reload
blizzz commentedon Oct 11, 2022
Yes, it's an absolute killer. Our instance is patched, as described above, right after the upgrade (as soon as i figured out where it happened).